Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SparseArrayImpl to pure Python #2065

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Move SparseArrayImpl to pure Python #2065

merged 4 commits into from
Sep 23, 2024

Conversation

kounelisagis
Copy link
Member

nguyenv
nguyenv approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor nits but overall looks good to me. We might want to consider adding in type annotations in this PR or a follow-up one.

tiledb/sparse_array.py Outdated Show resolved Hide resolved
tiledb/sparse_array.py Outdated Show resolved Hide resolved
tiledb/sparse_array.py Outdated Show resolved Hide resolved
tiledb/sparse_array.py Outdated Show resolved Hide resolved
tiledb/sparse_array.py Outdated Show resolved Hide resolved
tiledb/sparse_array.py Outdated Show resolved Hide resolved
tiledb/sparse_array.py Outdated Show resolved Hide resolved
@johnkerl johnkerl removed the request for review from KiterLuc September 20, 2024 17:44
@kounelisagis
Copy link
Member Author

I have some minor nits but overall looks good to me. We might want to consider adding in type annotations in this PR or a follow-up one.

Thanks for your comments! We have a dedicated story specifically for implementing type hints (and use mypy) across the entire project. It's always on my mind, but for this PR, I wanted to minimize changes compared to the Cython version.

@kounelisagis kounelisagis force-pushed the agis/move-sparse-array-to-pure-python branch from 9d4b889 to 2c468bb Compare September 20, 2024 20:11
@kounelisagis kounelisagis merged commit 6bbabf1 into dev Sep 23, 2024
33 checks passed
@kounelisagis kounelisagis deleted the agis/move-sparse-array-to-pure-python branch September 23, 2024 08:22
kounelisagis added a commit that referenced this pull request Oct 23, 2024
@kounelisagis
Move SparseArrayImpl to pure Python (#2065)
6f44946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenv nguyenv nguyenv approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kounelisagis @nguyenv