Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libtiledb version in readthedocs config #1919

Conversation

kounelisagis
Copy link
Member

Also fixes: WARNING: Invalid configuration value found: 'language = None'. Update your configuration to a valid language code. Falling back to 'en' (English).

Copy link

@kounelisagis kounelisagis force-pushed the agis/sc-35414/readthedocs-site-has-reverted-to-very-old-version branch from 3e7af4d to 77e4442 Compare March 12, 2024 12:50
@kounelisagis kounelisagis force-pushed the agis/sc-35414/readthedocs-site-has-reverted-to-very-old-version branch from 77e4442 to 16700e4 Compare March 12, 2024 14:06
@kounelisagis kounelisagis requested a review from ihnorton March 12, 2024 14:51
@kounelisagis kounelisagis marked this pull request as ready for review March 12, 2024 14:52
doc/source/conf.py Outdated Show resolved Hide resolved
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please try setuptools_scm before merging so we don't have to update manually.

@kounelisagis
Copy link
Member Author

LGTM but please try setuptools_scm before merging so we don't have to update manually.

Some other changes were made because newer versions of setuptools and setuptools_scm are needed. For example long_description is not available in thesetup()method of setup.py anymore. Everything was done according to this: How to modernize a setup.py based project?

(There are many more things they suggest for modernizing the setup.py)

@kounelisagis kounelisagis requested a review from ihnorton March 12, 2024 21:31
@kounelisagis kounelisagis force-pushed the agis/sc-35414/readthedocs-site-has-reverted-to-very-old-version branch from ed78cd5 to 6567dd9 Compare March 12, 2024 21:58
@ihnorton
Copy link
Member

(There are many more things they suggest for modernizing the setup.py)

Big +1 to cleaning this up, great observation. It's been on my list to discuss w/ you soon 😉. We can probably cut the size of the file by 95% by using scikit-build-core -- see how it's used in vector search to handle the extension build, and then the modernization should be really straightforward.

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but could you please do a test build by pushing this branch as release-test-sc35414? Then after ~1hr you should have wheels available here (just invited you to project). Make sure one of the wheels installs and imports correctly locally, and that the metadata looks the same as the last release on PyPI.

@ihnorton ihnorton requested a review from dudoslav March 13, 2024 02:03
@ihnorton ihnorton changed the title Update libtiledb version Update libtiledb version in readthedocs config Mar 13, 2024
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@kounelisagis
Copy link
Member Author

Overall LGTM, but could you please do a test build by pushing this branch as release-test-sc35414? Then after ~1hr you should have wheels available here (just invited you to project). Make sure one of the wheels installs and imports correctly locally, and that the metadata looks the same as the last release on PyPI.

I used tiledb-0.26.3-cp311-cp311-macosx_11_0_arm64.whl file found in drop folder.

conda create -n test_env python=3.11
conda activate test_env
pip install tiledb-0.26.3-cp311-cp311-macosx_11_0_arm64.whl
pip install numpy
python
>>> import tiledb
>>> from importlib import metadata
>>> dict(metadata.metadata('tiledb'))
{'Metadata-Version': '2.1', 'Name': 'tiledb', 'Version': '0.26.3', 'Summary': 'Pythonic interface to the TileDB array storage manager', 'Author-email': '"TileDB, Inc." <[email protected]>', 'Maintainer-email': '"TileDB, Inc." <[email protected]>', 'License': 'MIT', 'Project-URL': 'homepage, https://github.com/TileDB-Inc/TileDB-Py', 'Platform': 'any', 'Description-Content-Type': 'text/markdown', 'License-File': 'LICENSE', 'Description': '<a href="https://tiledb.com/"><img src="https://github.com/TileDB-Inc/TileDB/raw/dev/doc/source/_static/[email protected]" alt="TileDB logo" width="400"></a>\n\n\n[![Build Status](https://dev.azure.com/TileDB-Inc/CI/_apis/build/status/TileDB-Inc.TileDB-Py?branchName=dev)](https://dev.azure.com/TileDB-Inc/CI/_build/latest?definitionId=1&branchName=dev)\n![](https://raw.githubusercontent.com/TileDB-Inc/TileDB/dev/doc/anaconda.svg?sanitize=true)[![Anaconda download count badge](https://anaconda.org/conda-forge/TileDB-Py/badges/downloads.svg)](https://anaconda.org/conda-forge/TileDB-Py)\n\n\n# TileDB-Py\n\n*TileDB-Py* is a [Python](https://python.org/) interface to the [TileDB Storage Engine](https://github.com/TileDB-Inc/TileDB).\n\n# Quick Links\n\n* [Installation](https://docs.tiledb.com/developer/installation/quick-install)\n* [Build Instructions](https://docs.tiledb.com/main/how-to/installation/building-from-source/python)\n* [TileDB Documentation](https://docs.tiledb.com/main/)\n* [Python API reference](https://tiledb-inc-tiledb-py.readthedocs-hosted.com/en/stable)\n\n# Quick Installation\n\nTileDB-Py is available from either [PyPI](https://pypi.org/project/tiledb/) with ``pip``:\n\n
\npip install tiledb\n```\n\nor from conda-forge with\nconda or mamba:\n\n```\nconda install -c conda-forge tiledb-py\n```\n\nDataframes functionality (tiledb.from_pandas, Array.df[]) requires Pandas 1.0 or higher, and PyArrow 1.0 or higher.\n\n# Contributing\n\nWe welcome contributions, please see [CONTRIBUTING.md](CONTRIBUTING.md) for suggestions and\ndevelopment-build instructions. For larger features, please open an issue to discuss goals and\napproach in order to ensure a smooth PR integration and review process.\n'}

Copy link
Collaborator

@dudoslav dudoslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure that you can still produce wheel, so please:

  1. Create and install wheel
  2. Create and install sdist
  3. In all cases run import tiledb in python

@kounelisagis
Copy link
Member Author

LGTM, just make sure that you can still produce wheel, so please:

  1. Create and install wheel
  2. Create and install sdist
  3. In all cases run import tiledb in python
  1. Successfully installed wheel from azure devops.
  2. sdist
> python --version
Python 3.8.17
> pipx run build --sdist
> pip install dist/tiledb-0.26.4.dev3+dirty.tar.gz
> cd ..
> python
>>> import tiledb
>>> tiledb.version()
(0, 26, 4, 'dev3', 'dirty')
>>> tiledb.libtiledb.version()
(2, 20, 1)

@kounelisagis kounelisagis merged commit 0b14a6e into dev Mar 14, 2024
28 checks passed
@kounelisagis kounelisagis deleted the agis/sc-35414/readthedocs-site-has-reverted-to-very-old-version branch March 14, 2024 12:40
kounelisagis added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants