-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libtiledb version in readthedocs config #1919
Update libtiledb version in readthedocs config #1919
Conversation
This pull request has been linked to Shortcut Story #35414: TileDB-Py Readthedocs site has reverted to very old version. |
3e7af4d
to
77e4442
Compare
77e4442
to
16700e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please try setuptools_scm before merging so we don't have to update manually.
Some other changes were made because newer versions of setuptools and setuptools_scm are needed. For example (There are many more things they suggest for modernizing the setup.py) |
ed78cd5
to
6567dd9
Compare
Big +1 to cleaning this up, great observation. It's been on my list to discuss w/ you soon 😉. We can probably cut the size of the file by 95% by using scikit-build-core -- see how it's used in vector search to handle the extension build, and then the modernization should be really straightforward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but could you please do a test build by pushing this branch as release-test-sc35414
? Then after ~1hr you should have wheels available here (just invited you to project). Make sure one of the wheels installs and import
s correctly locally, and that the metadata looks the same as the last release on PyPI.
I used tiledb-0.26.3-cp311-cp311-macosx_11_0_arm64.whl file found in drop folder.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just make sure that you can still produce wheel, so please:
- Create and install wheel
- Create and install sdist
- In all cases run
import tiledb
in python
|
This reverts commit 0b14a6e.
Also fixes:
WARNING: Invalid configuration value found: 'language = None'. Update your configuration to a valid language code. Falling back to 'en' (English).