Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7 CI jobs #1916

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Conversation

kounelisagis
Copy link
Member

Removing Python 3.7 CI jobs from all GitHub workflows.

@kounelisagis kounelisagis requested a review from ihnorton March 8, 2024 12:22
Copy link

This pull request has been linked to Shortcut Story #42691: Remove Python 3.7 CI jobs.

@ihnorton
Copy link
Member

ihnorton commented Mar 8, 2024

Oh, also need to add exclusions for cp37 for the release wheels here:

CIBW_SKIP: "cp36-* *_i686 pp* *musllinux*"
CIBW_BUILD_VERBOSITY: 3
CIBW_ARCHS_MACOS: ""
macOS_py:
imageName: "macOS-12"
MACOSX_DEPLOYMENT_TARGET: 11
TILEDB_INSTALL: "$(Pipeline.Workspace)/.libtiledb_dist/$(LIBTILEDB_SHA)-macos-x86_64"
CIBW_ARCHS_MACOS: "x86_64"
CIBW_SKIP: "cp36-* pp*"
CIBW_TEST_SKIP: "cp37-*"
CIBW_BUILD_VERBOSITY: 3
macOS_arm64_py:
imageName: "macOS-12"
MACOSX_DEPLOYMENT_TARGET: 11
TILEDB_INSTALL: "$(Pipeline.Workspace)/.libtiledb_dist/$(LIBTILEDB_SHA)-macos-arm64"
CIBW_BUILD_VERBOSITY: 3
CIBW_ARCHS_MACOS: "arm64"
# NumPy is only available in CPython 3.8+ on macOS-arm64
CIBW_SKIP: "cp36-* cp37-* pp*"
windows_py:
imageName: "windows-latest"
CIBW_SKIP: "cp36-* *-win32 pp*"

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CI. Thanks!

@ihnorton ihnorton closed this Mar 8, 2024
@ihnorton ihnorton reopened this Mar 8, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kounelisagis kounelisagis requested a review from ihnorton March 9, 2024 00:17
@ihnorton ihnorton merged commit 2c693ca into dev Mar 9, 2024
28 checks passed
@ihnorton ihnorton deleted the agis/sc-42691/remove-python-3.7-ci-jobs branch March 9, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants