Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add context manager before enter .array_exists #1868

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix: Add context manager before enter .array_exists #1868

merged 1 commit into from
Nov 20, 2023

Conversation

p4perf4ce
Copy link
Contributor

What is this PR?

What changes

  • Just add .array_exists in from_csv into a context scope

Todo

  • Should add test where .from_csv have a cloud URI with custom context (not AmazonS3) such as minio.

ihnorton
ihnorton approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@p4perf4ce
Copy link
Contributor Author

@ihnorton Thanks for fast approval. Got this one E from test csv_fillna in Python 3.10 from pandas-core.

UserWarning: Could not infer format, so each element will be parsed individually, falling back to `dateutil`. To ensure parsing is consistent and as-expected, please specify a format.

Should we revise the test case or put an ignore for this warning? Thanks in advance.

@ihnorton ihnorton merged commit 85f0a30 into TileDB-Inc:dev Nov 20, 2023
20 checks passed
@p4perf4ce p4perf4ce deleted the fix/add-scope-ctx-dataframe branch November 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataFrame from_csv doesn't support alternative s3-compatible backend
2 participants
@p4perf4ce @ihnorton