Additional Support For Nullable Attributes #1836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As detailed in sc-34754, this fixes a bug found by a customer using the TileDB-SOMA Python API where the
SOMADataFrame
containing an enumerated nullable attribute was not being readback correctly. This highlights a larger deficit in the TileDB-Py codebase in which we have little support for writing nullable attributes outside of utilizingtiledb.from_pandas
with Pandas'sExtensionDtype
.Changes
pd.NA
,pa.na
,None
, etc.).PyQuery
results now also return the validity buffer.Future Proposals
numpy.ma
for nullable attributes.list
,tuple
). Internally, we check if the attribute.isnullable()
and then cast usingnp.ma.masked_invalid()
.