Added support for numpy complex types #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
requested changes
Apr 17, 2019
ihnorton
approved these changes
Apr 17, 2019
|
Just noting here that this change causes interpretation of 2-cell Other 2-cell numeric or string types should round-trip as-is (tests added for 2-cell int16 and '|S2'). |
|
Thanks @normanb 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support and tests for numpy complex data types.
There is an assumption that array sizes that are equal to two and are of type float 32/64 are to be interpreted as complex data types. This seems reasonable and follows numpy.