H.264 decoder support #1194

xornet-sl · 2021-02-04T03:11:01Z

This decoder supports H264 ustreamer from pikvm.org project.
I think we shoud also change rfb standard and add h264 there. Also I will work on server-side implementation in tigervnc.
H.264 streaming allows reduce network utilization, sometimes dramatically. So I beleive it should be useful.
This PR contains ffmpeg libav implementation for linux and media foundation for windows.
I added a cmake option ENABLE_H264, so it can be built without H.264 support if any problems occurs
Any comments are welcome!

mdevaev · 2021-02-04T03:16:36Z

See detailed description: #1187 (comment)

CendioOssman · 2021-02-04T09:35:00Z

Nice. :)

I think it is best if we nail down the behaviour of this encoding before we start getting in to the details of the code though. So could you get a first draft going for @rfbproto? Once we've nailed the details of how this should behave, we can start looking at if the code actually follows that behaviour. :)

mdevaev · 2021-02-04T09:44:48Z

I'll take care of it immediately ;)

The story: - TigerVNC/tigervnc#1187 The reference implementation: - TigerVNC/tigervnc#1194

mdevaev · 2021-02-04T12:35:29Z

@CendioOssman here the draft: rfbproto/rfbproto#39

xornet-sl · 2021-02-04T14:46:55Z

About package building: Deb-based systems have libav* and ffmpeg in their repos but rpm-based systems don't. I don't have any experiense with building packages under rpm-based systems. Also I have no macOS nearby to debug building proccess there too. It would be great if anyone could help me with these systems!

CendioOssman · 2021-02-04T15:02:06Z

Red Hat derived things do not include ffmpeg and such because of patent threats. They have some form of OpenH264 though.

Red Hat users generally use rpmfusion to get things that Red Hat refuses to package.

xornet-sl · 2021-02-04T15:10:02Z

Red Hat users generally use rpmfusion to get things that Red Hat refuses to package.

Yes, I know that, but how can I reference this repo as a dependency? Is there some right way to do so?

xornet-sl · 2021-02-04T15:23:15Z

arghhh.. I found some issues with versions of ffmpeg. older versions have a different API and older systems won't work. It is time to do more #ifdef logic 🤬

CendioOssman · 2021-02-04T16:07:54Z

Red Hat users generally use rpmfusion to get things that Red Hat refuses to package.

Yes, I know that, but how can I reference this repo as a dependency? Is there some right way to do so?

If you're talking about our Travis builds, then you probably shouldn't. Those builds should target a standard Red Hat. So this feature will have to be disabled there.

xornet-sl · 2021-02-04T18:43:09Z

travis is useless....

 library/ubuntu
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
The command "docker build -t tigervnc/$DOCKER .travis/$DOCKER" failed and exited with 1 during .
Your build has been stopped.

Can we restart a single job instead of queueing a full rebuild again?

CendioOssman · 2021-02-08T11:34:09Z

Yes, at least I can. But it might be because I'm an admin of the project.

I've poked Travis support about this. We'll see what they say about getting those caches working properly.

QuattroCS · 2021-03-15T00:57:12Z

@xornet-sl got past the cmake, got 3 errors on make (mac os x 10.15.7)

/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:51:5: error: multiple initializations given for non-static member 'supportsLocalCursor'
    supportsLocalCursor(false), supportsCursorPosition(false),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:46:5: note: previous initialization is here
    supportsLocalCursor(false), supportsDesktopResize(false),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:52:5: error: multiple initializations given for non-static member 'supportsDesktopResize'
    supportsDesktopResize(false), supportsLEDState(false),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:46:33: note: previous initialization is here
    supportsLocalCursor(false), supportsDesktopResize(false),
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:52:35: error: multiple initializations given for non-static member 'supportsLEDState'
    supportsDesktopResize(false), supportsLEDState(false),
                                  ^~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:47:5: note: previous initialization is here
    supportsLEDState(false),
    ^~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
make[2]: *** [common/rfb/CMakeFiles/rfb.dir/CConnection.cxx.o] Error 1
make[1]: *** [common/rfb/CMakeFiles/rfb.dir/all] Error 2
make: *** [all] Error 2

QuattroCS · 2021-03-15T01:23:12Z

In file included from /Users/QuattroCS/TigerVNC/tigervnc/common/rfb/Decoder.cxx:30:
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/H264Decoder.h:78:23: error: in-class initialization of non-static data member is a C++11 extension [-Werror,-Wc++11-extensions]
      SwsContext* sws = NULL;
                      ^
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/H264Decoder.h:79:26: error: in-class initialization of non-static data member is a C++11 extension [-Werror,-Wc++11-extensions]
      uint8_t* swsBuffer = NULL;
                         ^
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/H264Decoder.h:80:34: error: in-class initialization of non-static data member is a C++11 extension [-Werror,-Wc++11-extensions]
      rdr::U8* h264AlignedBuffer = NULL;
                                 ^
3 errors generated.
make[2]: *** [common/rfb/CMakeFiles/rfb.dir/Decoder.cxx.o] Error 1
make[1]: *** [common/rfb/CMakeFiles/rfb.dir/all] Error 2
make: *** [all] Error 2

xornet-sl · 2021-03-15T01:23:26Z

@xornet-sl got past the cmake, got 3 errors on make (mac os x 10.15.7)

/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:51:5: error: multiple initializations given for non-static member 'supportsLocalCursor'
    supportsLocalCursor(false), supportsCursorPosition(false),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:46:5: note: previous initialization is here
    supportsLocalCursor(false), supportsDesktopResize(false),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:52:5: error: multiple initializations given for non-static member 'supportsDesktopResize'
    supportsDesktopResize(false), supportsLEDState(false),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:46:33: note: previous initialization is here
    supportsLocalCursor(false), supportsDesktopResize(false),
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:52:35: error: multiple initializations given for non-static member 'supportsLEDState'
    supportsDesktopResize(false), supportsLEDState(false),
                                  ^~~~~~~~~~~~~~~~~~~~~~~
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/CConnection.cxx:47:5: note: previous initialization is here
    supportsLEDState(false),
    ^~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
make[2]: *** [common/rfb/CMakeFiles/rfb.dir/CConnection.cxx.o] Error 1
make[1]: *** [common/rfb/CMakeFiles/rfb.dir/all] Error 2
make: *** [all] Error 2

Ooops. My fault, wrong merge, sorry. Fixed

QuattroCS · 2021-03-15T01:24:14Z

@xornet-sl thank you sir

got another error elsewhere

xornet-sl · 2021-03-15T01:32:23Z

In file included from /Users/QuattroCS/TigerVNC/tigervnc/common/rfb/Decoder.cxx:30:
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/H264Decoder.h:78:23: error: in-class initialization of non-static data member is a C++11 extension [-Werror,-Wc++11-extensions]
      SwsContext* sws = NULL;
                      ^
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/H264Decoder.h:79:26: error: in-class initialization of non-static data member is a C++11 extension [-Werror,-Wc++11-extensions]
      uint8_t* swsBuffer = NULL;
                         ^
/Users/QuattroCS/TigerVNC/tigervnc/common/rfb/H264Decoder.h:80:34: error: in-class initialization of non-static data member is a C++11 extension [-Werror,-Wc++11-extensions]
      rdr::U8* h264AlignedBuffer = NULL;
                                 ^
3 errors generated.
make[2]: *** [common/rfb/CMakeFiles/rfb.dir/Decoder.cxx.o] Error 1
make[1]: *** [common/rfb/CMakeFiles/rfb.dir/all] Error 2
make: *** [all] Error 2

fixed

QuattroCS · 2021-03-15T01:35:10Z

@xornet-sl make and make dmg passed woohoo thank you.

now i need to figure out how to include dependencies in the dmg.

xornet-sl · 2021-03-15T01:36:47Z

@xornet-sl make and make dmg passed woohoo thank you.

now i need to figure out how to include dependencies in the dmg.

Thank you very much for helping us!

QuattroCS · 2021-03-15T01:38:03Z

@xornet-sl make and make dmg passed woohoo thank you.
now i need to figure out how to include dependencies in the dmg.

Thank you very much for helping us!

Absolutely, thank you for the quick responses.

can you point me in the right direction on the dependencies being included in the dmg?

xornet-sl · 2021-03-15T01:41:42Z

@xornet-sl make and make dmg passed woohoo thank you.
now i need to figure out how to include dependencies in the dmg.

Thank you very much for helping us!

Absolutely, thank you for the quick responses.

can you point me in the right direction on the dependencies being included in the dmg?

Unfortunately I have no experience with OSX at all :(
What changes did you do in cmake to build this pull request on OSX?

QuattroCS · 2021-03-15T01:46:36Z

Unfortunately I have no experience with OSX at all :(
What changes did you do in cmake to build this pull request on OSX?

ok no worries

no changes - specifically - I had to brew install
libav - found that in your doc in travis
ffmpeg - found that in the comments
gettext - by checking the first cmake i did
gnutls - from the build doc
jpeg - from cmake error
fltk - i dont remember

i'm in mac os x 10.15.7

i dont know if other things i have installed were used in this build.

xornet-sl · 2021-03-15T01:52:54Z

i dont know if other things i have installed were used in this build.

I think ffmpeg/libav should be just enough because this PR adds includes only for ffmpeg/libav header files. I just have no mac to build it by my own hands :) So I think we just need somehow to add ffmpeg/libav deps and it should be nice.

QuattroCS · 2021-03-15T01:54:02Z

i dont know if other things i have installed were used in this build.

I think ffmpeg/libav should be just enough because this PR adds includes only for ffmpeg/libav header files. I just have no mac to build it by my own hands :) So I think we just need somehow to add ffmpeg/libav deps and it should be nice.

i edited a couple more, jpeg was def stuck on cmake and it got past with it.

xornet-sl · 2021-03-15T01:54:55Z

gettext - by checking the first cmake i did
gnutls - from the build doc
jpeg - from cmake error
fltk - i dont remember

All these deps should be already at their place. They have no relation to this particular PR

QuattroCS · 2021-03-15T01:56:13Z

All these deps should be already at their place. They have no relation to this particular PR

understood, i didn't want to leave any info behind.

xornet-sl · 2021-03-15T12:52:34Z

@CendioOssman Hi, I see that travis has gone somewhere. Something went wrong with CI?

xornet-sl · 2022-01-20T22:52:13Z

Rebased and squashed everything on top of current master. @CendioOssman please check it

.github/workflows/build.yml

xornet-sl · 2022-01-21T04:23:14Z

@zhangyoufu Thanks. fixed.
Updated: found these libavdevice & libavformat in debian control files as build dependencies. Fixed too.

common/os/Mutex.h

Linux implementation using ffmpeg

CMakeLists.txt

xornet-sl · 2022-01-21T15:29:51Z

@CendioOssman All checks have passed! So, could we merge it now?

CendioOssman · 2022-01-21T15:43:57Z

Looks good. Thanks for all the hard work! :)

xornet-sl · 2022-01-21T15:45:36Z

Looks good. Thanks for all the hard work! :)

It's not over. I'm starting to work on server-side implementation

xornet-sl · 2022-01-21T15:46:36Z

Hooray! Thank you!

bphinz · 2022-01-25T12:10:16Z

I get the following errors on the windows builds now: [ 38%] Building CXX object common/rfb/CMakeFiles/rfb.dir/H264Decoder.cxx.obj In file included from /home/bphinz/workspace/win32-binaries/tigervnc-1.12.80-20220125git0eab3508/common/rfb/H264Decoder.cxx:31:0: /home/bphinz/workspace/win32-binaries/tigervnc-1.12.80-20220125git0eab3508/common/rfb/H264DecoderContext.h:45:26: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 bool initialized = false; ^ /home/bphinz/workspace/win32-binaries/tigervnc-1.12.80-20220125git0eab3508/common/rfb/H264Decoder.cxx: In member function 'virtual void rfb::H264Decoder::decodeRect(const rfb::Rect&, const void*, size_t, const rfb::ServerParams&, rfb::ModifiablePixelBuffer*)': /home/bphinz/workspace/win32-binaries/tigervnc-1.12.80-20220125git0eab3508/common/rfb/H264Decoder.cxx:118:7: warning: 'auto' changes meaning in C++11; please remove it [-Wc++0x-compat] auto excecc_ctx = contexts.front(); ^ /home/bphinz/workspace/win32-binaries/tigervnc-1.12.80-20220125git0eab3508/common/rfb/H264Decoder.cxx:118:12: error: 'excecc_ctx' does not name a type auto excecc_ctx = contexts.front(); ^ /home/bphinz/workspace/win32-binaries/tigervnc-1.12.80-20220125git0eab3508/common/rfb/H264Decoder.cxx:119:14: error: 'excecc_ctx' was not declared in this scope delete excecc_ctx; ^ make[2]: *** [common/rfb/CMakeFiles/rfb.dir/H264Decoder.cxx.obj] Error 1 make[1]: *** [common/rfb/CMakeFiles/rfb.dir/all] Error 2 make: *** [all] Error 2 Build step 'Execute shell' marked build as failure Archiving artifacts Finished: FAILURE

…

On Fri, Jan 21, 2022 at 10:46 AM Vladimir Sukhonosov < ***@***.***> wrote: Hooray! Thank you! — Reply to this email directly, view it on GitHub <#1194 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB45M3JZ26ECMFPPGK65TFDUXF5WTANCNFSM4XCAN4KQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

CendioOssman · 2022-01-25T12:40:58Z

I guess you also have a rather old version of gcc? :)

Normally we avoid C+11 since stuff like RHEL 7 doesn't support that fully. I didn't notice it here since we don't build these parts for RHEL, and once I did I hoped other platforms would have more updated gcc.

bphinz · 2022-01-25T14:26:54Z

I guess you also have a rather old version of gcc? :)

MXE's current version (5.5.0)

…

Message ID: ***@***.***>

xornet-sl · 2022-01-25T19:19:20Z

@bphinz @CendioOssman
Opened #1419 to fix this
@bphinz you can try to compile this branch to test if everything is ok now

xornet-sl · 2022-01-25T19:23:25Z

@CendioOssman could you please answer to me via e-mail? I wrote on e-mail that is in your commits a few days ago. I have some questions to brainstorm with you about Encoder support. please answer me to [email protected] if you have some time

bphinz · 2022-01-26T04:02:55Z

yes, that works

…

On Tue, Jan 25, 2022 at 2:19 PM Vladimir Sukhonosov < ***@***.***> wrote: @bphinz <https://github.com/bphinz> @CendioOssman <https://github.com/CendioOssman> Opened #1419 <#1419> to fix this @bphinz <https://github.com/bphinz> you can try to compile this branch to test if everything is ok now — Reply to this email directly, view it on GitHub <#1194 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB45M3OLVOBBRGTTA4BZWTDUX3ZUNANCNFSM4XCAN4KQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

CendioOssman · 2022-01-26T13:00:50Z

I sent you a reply the other day. gmail has been acting up lately though, so check if it ended up in a spam folder or such.

mdevaev mentioned this pull request Feb 4, 2021

H264 for vncviewer #1187

Closed

mdevaev added a commit to mdevaev/rfbproto that referenced this pull request Feb 4, 2021

Pi-KVM H.264 Encoding

76ed1d6

The story: - TigerVNC/tigervnc#1187 The reference implementation: - TigerVNC/tigervnc#1194

mdevaev mentioned this pull request Feb 4, 2021

Open H.264 Encoding rfbproto/rfbproto#39

Merged

xornet-sl force-pushed the h264dec branch from ae2fbcd to dddc0d2 Compare February 4, 2021 14:43

xornet-sl force-pushed the h264dec branch from 42bc575 to 3a74953 Compare January 20, 2022 22:50

zhangyoufu reviewed Jan 21, 2022

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

xornet-sl force-pushed the h264dec branch from 3a74953 to 06759a9 Compare January 21, 2022 04:21

xornet-sl force-pushed the h264dec branch from 06759a9 to 5946f09 Compare January 21, 2022 04:27

xornet-sl requested a review from CendioOssman January 21, 2022 04:34

xornet-sl force-pushed the h264dec branch 2 times, most recently from 24dfd2e to 539e0cc Compare January 21, 2022 05:08

zhangyoufu reviewed Jan 21, 2022

View reviewed changes

common/os/Mutex.h Outdated Show resolved Hide resolved

xornet-sl force-pushed the h264dec branch from 50cb790 to 9e0848f Compare January 21, 2022 05:20

xornet-sl and others added 2 commits January 21, 2022 08:26

H264 Decoder

03df448

Linux implementation using ffmpeg

support H264 decoding with MediaFoundation on Windows

139e5e9

xornet-sl force-pushed the h264dec branch from 9e0848f to 139e5e9 Compare January 21, 2022 05:26

zhangyoufu reviewed Jan 21, 2022

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

CendioOssman approved these changes Jan 21, 2022

View reviewed changes

CendioOssman merged commit ec54fc8 into TigerVNC:master Jan 21, 2022

xornet-sl deleted the h264dec branch January 21, 2022 15:49

Fearyncess mentioned this pull request Jul 31, 2024

tigervnc (TigerVNC): update to 1.14.0 AOSC-Dev/aosc-os-abbs#7388

Closed

6 tasks

H.264 decoder support #1194

H.264 decoder support #1194

Conversation

xornet-sl commented Feb 4, 2021

mdevaev commented Feb 4, 2021 • edited Loading

CendioOssman commented Feb 4, 2021

mdevaev commented Feb 4, 2021

mdevaev commented Feb 4, 2021

xornet-sl commented Feb 4, 2021

CendioOssman commented Feb 4, 2021

xornet-sl commented Feb 4, 2021 • edited Loading

xornet-sl commented Feb 4, 2021

CendioOssman commented Feb 4, 2021

xornet-sl commented Feb 4, 2021 • edited Loading

CendioOssman commented Feb 8, 2021

QuattroCS commented Mar 15, 2021 • edited Loading

QuattroCS commented Mar 15, 2021 • edited Loading

xornet-sl commented Mar 15, 2021

QuattroCS commented Mar 15, 2021

xornet-sl commented Mar 15, 2021

QuattroCS commented Mar 15, 2021

xornet-sl commented Mar 15, 2021 • edited Loading

QuattroCS commented Mar 15, 2021

xornet-sl commented Mar 15, 2021

QuattroCS commented Mar 15, 2021 • edited Loading

xornet-sl commented Mar 15, 2021 • edited Loading

QuattroCS commented Mar 15, 2021

xornet-sl commented Mar 15, 2021

QuattroCS commented Mar 15, 2021

xornet-sl commented Mar 15, 2021

xornet-sl commented Jan 20, 2022

xornet-sl commented Jan 21, 2022 • edited Loading

xornet-sl commented Jan 21, 2022 • edited Loading

CendioOssman commented Jan 21, 2022

xornet-sl commented Jan 21, 2022

xornet-sl commented Jan 21, 2022

bphinz commented Jan 25, 2022 via email

CendioOssman commented Jan 25, 2022

bphinz commented Jan 25, 2022 via email

xornet-sl commented Jan 25, 2022

xornet-sl commented Jan 25, 2022

bphinz commented Jan 26, 2022 via email

CendioOssman commented Jan 26, 2022

mdevaev commented Feb 4, 2021 •

edited

Loading

xornet-sl commented Feb 4, 2021 •

edited

Loading

xornet-sl commented Feb 4, 2021 •

edited

Loading

QuattroCS commented Mar 15, 2021 •

edited

Loading

QuattroCS commented Mar 15, 2021 •

edited

Loading

xornet-sl commented Mar 15, 2021 •

edited

Loading

QuattroCS commented Mar 15, 2021 •

edited

Loading

xornet-sl commented Mar 15, 2021 •

edited

Loading

xornet-sl commented Jan 21, 2022 •

edited

Loading

xornet-sl commented Jan 21, 2022 •

edited

Loading