Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont reset invoice generator form on failed submission #652

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

patrr2
Copy link

@patrr2 patrr2 commented Mar 11, 2025

Description

Closes #607

Testing checklist:

  • Now error on submission doesn't cause form reset
  • Successfull submission resets form
  • Exactly same body is sent to the endpoint on submission (i.e. behaves the same as prev commit)

Before submitting the PR, please make sure you do the following

  • If your PR is related to a previously discussed issue, please link to it here.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Make sure the commit history is linear, up-to-date with main branch and does not contain any erroneous changes

Formatting and linting

  • Format code with pnpm format and lint the project with pnpm lint

@lajp lajp self-requested a review March 11, 2025 07:24
@lajp
Copy link
Member

lajp commented Mar 11, 2025

Hi, this doesn't seem to work for me. The form still gets cleared on failed server-side validation

@patrr2
Copy link
Author

patrr2 commented Mar 11, 2025

Okei, tutkitaan asiaa miitissä

@lajp
Copy link
Member

lajp commented Mar 11, 2025

Hi, this doesn't seem to work for me. The form still gets cleared on failed server-side validation

nvm, I accidentally tested the wrong thing. Works like a charm!

@lajp lajp merged commit f75f7a4 into Tietokilta:main Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoice generator clears all fields if one field is incorrect
2 participants