Fix 5483 & 3483 #5504
Merged
Fix 5483 & 3483 #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This now includes fixes for #3483, and sanitizers for "reserved codes" like "com5" on Windows, or certain character-sets on *nix. |
|
Thanks @joshuafontany, intricate stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5483 by storing a relative path in the $tw.boot.files fileInfo objects for any tiddler marked
isEditableFile. This is replaced with '' (an empty string) if missing, and is then used in the tests that check the "new" filepath against the known writable locations. We have to test against both, so a new check has been added. The previous calls to the tiddler storing this info have been removed as a security vulnerability.@Jermolene This is good to merge, along with #5416. Mahalo (thanks)!!!