-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codelist links are broken #80
Comments
Looks like the service we used to use for "pretty" view of a CSV has gone. Would you like the link to go to https://standard.threesixtygiving.org/en/latest/technical/codelists/#regrant-type instead?
Looks like "To Individuals Details:Grant Purpose" is missing, I'll do some digging into why.
Yes, I think this is due to enums. I think we should be able to combine this with the codelist errors, I can do some initial investigation into that. |
Thanks Ben
Yes, I think linking to the more user friendly codelist tables for those we manage via CSVs would be great. Not sure what to suggest for the enums, as we wanted to avoid having to put such long lists in the docs.
It did appear at points I played around by adding and removing errors, so I don't think it's a fixed issue effecting just one codelist, but something to do with a max number to show maybe? |
#80 This replaced a now broken link to data pipes.
#80 This replaced a now broken link to data pipes. Also reorders INSTALLED_APPS so that cove_360 templates overwrite lib-cove-web (cove) ones.
#80 This replaced a now broken link to data pipes. Also reorders INSTALLED_APPS so that cove_360 templates overwrite lib-cove-web (cove) ones.
#80 This replaced a now broken link to data pipes. Also reorders INSTALLED_APPS so that cove_360 templates overwrite lib-cove-web (cove) ones.
#80 This replaced a now broken link to data pipes. Also reorders INSTALLED_APPS so that cove_360 templates overwrite lib-cove-web (cove) ones.
Pulls in this lib-cove PR OpenDataServices/lib-cove#114 to fix #80
jsonschema 4 is not compatible, because it doesn't use our custom oneOf validator (although it looks like this should be possible). Pulls in this lib-cove PR OpenDataServices/lib-cove#114 to fix #80
jsonschema 4 is not compatible, because it doesn't use our custom oneOf validator (although it looks like this should be possible). Pulls in this lib-cove PR OpenDataServices/lib-cove#114 to fix #80
I think everything in this issue has been done, except for fixing the display of enums vs non-enums, which I've split out into it's own issue #86 |
When incorrect codes are included in closed codelist the DQT provides an error message with a hyperlink to the codelist, however these links all direct to the wrong place, for example
Also to note, there are 5 codelist fields with errors in the example file being tested but only 4 of them are listed as having problems - see feedback
There are also only 'Other errors' with specifics about the issue for currency and country code (which are the two enum'd codelists, so is this influencing this behavour?)
The dummy data being tested is attached.
Dummy-data-for-testing-codeerrors.xlsx
The text was updated successfully, but these errors were encountered: