Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pgx to v5.7.2 and update transactionID type to pgtype.Uint64 #43

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Abdullah-AlAttar
Copy link
Contributor

I came across this issue while trying the new pgx interface, jackc/pgx#2137
Simply changing the type fixes the issue.

@michaelsmanley-ncsasports

+1 for this fix. Cannot currently consume messages from the SQL pubsub with any flavor of Postgres driver.

@lyubchev
Copy link

Any plans on merging this soon?

@m110
Copy link
Member

m110 commented Jan 30, 2025

Thank you @Abdullah-AlAttar. I planned to look into the tests as they're flaky for some reason but this has to wait, so I'll merge it now not to block people.

@m110 m110 merged commit 4fa1e7a into ThreeDotsLabs:master Jan 30, 2025
3 of 4 checks passed
@m110
Copy link
Member

m110 commented Jan 30, 2025

@Abdullah-AlAttar acutally, looking at the tests I think more work is needed on querying to make it work:

[watermill] 2025/01/30 15:44:57.065443 backoff_manager.go:58: 	level=ERROR msg="Error querying for message" consumer_group=test err="could not unmarshal message from query: could not scan message row: sql: Scan error on column index 1, name "transaction_id": cannot scan []uint8" subscriber_id=01JJVY5Y8XR0HTKNS8A8HMMGCW topic=topic-54c30d57-b9c3-4abc-b2e4-c47fe7710b92 wait_time=1s 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants