improvement(Stock Mouvement Document)

[lomamech]

Set Voucher reference to

• Adjustment Receipt
• Donation Receipt
• Integration Receipt
• Purchase Receipt
• Loss Receipt
• Patient Receipt

closes #2694

[lomamech]

@mbayopanda can you review this PR

[jniles]

Made a few comments on the code - haven't checked the functionality yet, but the idea is the right one!

[jniles]

Does every receipt need sqlGetVoucherReference? If so, I would make it a function and put it in the stock/reports/common.js.

Like this:

function getVoucherReferenceForStockMovement(documentUuid) {
  const sql = `
    SELECT v.uuid, dm.text AS voucher_reference
    FROM voucher AS v
    JOIN voucher_item AS vi ON vi.voucher_uuid = v.uuid
    JOIN document_map AS dm ON dm.uuid = v.uuid
    WHERE vi.document_uuid = ?
    LIMIT 1;
  `;

  return db.exec(sql, [db.bid(documentUuid)]);
}

exports.getVoucherReferenceForStockMovement = getVoucherReferenceForStockMovement;

Then every stock module can import it and just use:

const { getVoucherReferenceForStockMovement }  = require('../common');

// later ..

const results = await q.all([
  db.exec(sql, [db.bid(documentUuid)]), 
  getVoucherReferenceForStockMovement(documentUuid),
]);

// etc

This would be more DRY.

[jniles]

By the way, you don't need to use q here. You can just call the native Promise.all() directly.

[lomamech]

@jniles all checks have passed

[jniles]

Looks good to me. Thanks a ton!

[jniles]

bors r+

[bors]

Build succeeded

• continuous-integration/appveyor/branch
• continuous-integration/travis-ci/push