Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optional MilGP Variants component - MilGP Grey and Black #207

Merged
merged 4 commits into from
May 8, 2023

Conversation

JoramD0
Copy link
Member

@JoramD0 JoramD0 commented May 4, 2023

When merged this pull request will:

  • Add grey and black versions of various vests and backpacks from Military Gear Pack

Textures provided by @GilleeDoo.
Kept naming in line with MilGP.

Continuation of GTArmory #150.

@jonpas
Copy link
Member

jonpas commented May 5, 2023

Kept naming in line with MilGP.

We should use the Services naming.

@JoramD0
Copy link
Member Author

JoramD0 commented May 5, 2023

I disagree, That means we'd call the colors Grey & Black instead of the current 3 letters (GRY & BLK).
That ends up with 2 color variants in the list of MilGP vests to not match naming wise.

@jonpas
Copy link
Member

jonpas commented May 6, 2023

Display Names are fine, class names is what I want named same as Services.

@jonpas jonpas changed the title MilGP Variants - Retexture MilGP to Grey and Black Add Optional MilGP Variants component - MilGP Grey and Black May 8, 2023
@jonpas jonpas merged commit 8eb0660 into master May 8, 2023
@jonpas jonpas deleted the milgp-optional branch May 8, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants