Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skewed Arrows, 0.7.X support and more! #47

Open
wants to merge 146 commits into
base: main
Choose a base branch
from

Conversation

EdwhakKB
Copy link

@EdwhakKB EdwhakKB commented Sep 3, 2023

This is a big work inside modcharting tools (adding more modifiers, a tutorial for lua and a skew sprites [simulates 3d somehow])
Huge thanks to Glowsoony for the help with 0.7.x and Skewed Sprite fix!

EdwhakKB added 7 commits July 25, 2023 13:12
fixes for 0.7 and a few stuff for modchart editor for begginers
Added fixes for 0.7 version of Psych engine / improved a bit the modchart editor with some new stuff for begginers
i did it wrong lmao
Since it looks better like this
needed
since i think this can fix a lot of stuff but if you want and can, remove it lol
SkewedArrows, fixed stuff, added 0.7.x support, new modifiers etc etc
Copy link

@moxie-coder moxie-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good so far

@moxie-coder
Copy link

Yo gonna use this! But what about specifying the version? Since there are 2 version inside the source folder, I'm using psych 6.3

use the 0.6.3 folder then

Copy link
Contributor

@Vortex2Oblivion Vortex2Oblivion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glowsoony
Copy link

Please note that this PR is a test! Skewed notes are still being tested on to see the limits it may have! so far its already looking complete from the code me and Edwhak have seen. Please know 0.7.x is still experimental and I am testing that Version while Edwhak is testing 0.6.3 and so far skewed notes are a major success.

Added support for 0.6.X and 0.7.X vers, also fixed some modifiers and added difficulty modcharts
MINIMAL SPELLING MISTAKE OH NO
I forgot some 0.7.X stuff so...
Added a fix for all crash issues
EVERY 5 SECONDS A NEW BUG LMAO
4 hours of PAIN with glowsoony to try fix this shit lmao
Asked by Vortex since man didn't wanted use copy and paste code edition lmao, if there is any bug with ur leather engine tell me
I FORGOT MODCHART DIFFICULTY 0.7 SUPPORT XDDDDD
at least its way better ig
i expected 1 or 2, not 50
BRO
I hope i finally fixed this, i just want to rest now...
Finally working all 0.7 stuff!
Some people was complaining about this issue so i just fixed it ig lmao have fun
forgot
Added scroll support for Skew modifier, making able to choose if its forced to skew at that dir, or if it depends on upscroll or downscroll, ah yeah notes mods too lmao
FINALLY BRO LMAO
@UsernamesAreNice
Copy link

I have a problem. Error with compiling.

C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/Modifier.hx:13: characters 8-17 : Type not found : PlayState C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/Modifier.hx:14: characters 8-12 : Type not found : Note C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/PlayfieldRenderer.hx:27: characters 8-17 : Type not found : PlayState C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/PlayfieldRenderer.hx:28: characters 8-12 : Type not found : Note C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/PlayfieldRenderer.hx:42: characters 24-33 : Type not found : StrumNote C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/NoteMovement.hx:13: characters 8-17 : Type not found : PlayState C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/NoteMovement.hx:14: characters 8-12 : Type not found : Note C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartUtil.hx:14: characters 8-17 : Type not found : PlayState C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartUtil.hx:15: characters 8-12 : Type not found : Note source/psychlua/FunkinLua.hx:56: characters 17-30 : Expected }

@Rom4chek
Copy link

Uhh my sustains are invisible

@glowsoony
Copy link

glowsoony commented Jun 13, 2024

Some things to know. (For Psych ONLY)

  1. If your on 0.7.x (0.7 or higher) turn off GPU Caching, this is not a bug, what happens is that GPU Caching destroys the image and re builds it, storing the memory on GPU instead of CPU, turn it off.

  2. Check what version you put in your project.xml! define the version as <define name="PSYCHVERSION" value=""/> the value is the version your on so it would be "0.6.3" or whatever version your on! also be sure to define the variable "PSYCH" as <define name="PSYCH" /> If you define psych and define the psychversion than it will look for what things to import, this is important! As what imports is depending both on the engine (defined as PSYCH) and the (PSYCHVERSION defined as whatever version you put).

@Rom4chek
Copy link

wait, variable backupGpu doesn't work at all?

@glowsoony
Copy link

In the editor if it's not visible Im check that out since it should be, but if neither in playstate nor modcharteditor then it's a bug (in the case that GPU rendering is on) but if it's not working in the editor try with it off and if it works then I'll check that out

@Rom4chek
Copy link

firstly i had them invisible in playstate, but when i entered editor they became visible even in playstate

@glowsoony
Copy link

If they became visible after entering the editor then I see, it is the fact GPU Rendering is turned on, the Editor has support for turning it off but by default PlayState won't clearly since the support is only for the editor.

@Rom4chek
Copy link

weird

@Rom4chek
Copy link

also question i'm kinda dumb lol, how skew modifier works lol, i think i don't understand smth

@glowsoony
Copy link

SkewModifier really doesn't work sometimes or Idk if it works cause I find that sometimes its depending on a few things, but Skew works by applying a skew to the receptors such as looking like its bending forward

@EdwhakKB
Copy link
Author

also question i'm kinda dumb lol, how skew modifier works lol, i think i don't understand smth

Hey, im Mt creator and i'll tell, Skew modifier its a modifier that uses subValues (X.Y,XD,YD) so in order to properly make it work you should first enable the base modifier

(have in mind it should already been created)
lua should be:

set(beat, [[
1,skewMod
]])

in editor you go to events, pick the skew modifier and add value 1 (add time to 0 to instantly do it since "SET" in editor doesn't work properly yet)

then you are able to modify sub values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants