Skip to content

Commit

Permalink
Do not inherit stdin on executed command
Browse files Browse the repository at this point in the history
This can lead to child hanging waiting for output which will never come.

See issue WeblateOrg#1308

Signed-off-by: Michal Čihař <[email protected]>
  • Loading branch information
nijel committed Jan 4, 2017
1 parent f1a4ae0 commit 3dcd893
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions weblate/trans/vcs.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ def _popen(cls, args, cwd=None, err=False):
env=cls._getenv(),
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
stdin=subprocess.PIPE,
)
output, output_err = process.communicate()
retcode = process.poll()
Expand Down

0 comments on commit 3dcd893

Please sign in to comment.