fix: check androidX version at early build process before really launching build #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangJonghun
reviewed
Jan 28, 2025
| @@ -35,6 +38,11 @@ buildscript { | |||
| } else { | |||
| println("Kotlin version is correct: $kotlin_version") | |||
| } | |||
| if (!isVersionAtLeast(androidx_version, requiredAndroidxVersion)) { | |||
| throw new GradleException("AndroidX version mismatch: Project is using Kotlin version $requiredAndroidxVersion, but it must be at least $requiredAndroidxVersion. Please update the Kotlin version.") | |||
There was a problem hiding this comment.
@freeboub
It says about Kotlin version, so I think that should be fixed
There was a problem hiding this comment.
It is not fixed in the release.
Also, it mentions requiredAndroidxVersion instead of androidx_version for the project's current AndroidX version.
There was a problem hiding this comment.
Oh, nvm. it already fixed within #4420
thanks @ThomasGuenard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try to improve developer experience by checking androidX version before launching the build
Motivation
fix: #4387
Changes
check used androidX version before launching build process
Test plan
On sample