-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to define poster
props as Image type and render poster as custom component
#3972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but let's make it so we don't introduce breaking changes
@KrzysztofMoch Thanks for the review. It should look ok now :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments, but this is a good feature ! Thank you !
Thanks for review! I'll refactor the code |
@moskalakamil please update the type of |
Hi @seyedmostafahasani! I'm not sure what do you mean, can u explain more? I added new type for |
Hey, I was suggestion to update type of |
poster
props and render poster
as custom componentposter
props as Image type and render poster as custom component
code changes looks good to me |
224ee59
to
cddb5b5
Compare
@freeboub @KrzysztofMoch conflicts resolved 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅ but there are conflicts again 😅
We need to be faster 😅 I resolved them @KrzysztofMoch |
Waiting for green CI and I will merge |
Thanks 🚀 |
Summary
I added the ability for the user to fully manage the poster, including: managing all props, rendering their own poster, and fixed a bug with displaying the poster
Closes #3013
Motivation
Issue
Changes
posterProps
to allow user manage all of the poster props (incl. source, resizeMode and all others)renderPoster
props, to allow user render poster as a componentTest plan
Run basic example ;)