Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Poster issue fix #1779

Merged
merged 6 commits into from
Nov 26, 2019
Merged

Audio Poster issue fix #1779

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44d2bfb
Merge pull request #1 from react-native-community/master
Jul 17, 2019
3c6ecfb
Update Video.js
Aug 15, 2019
01f37c5
Merge pull request #3 from react-native-community/master
sridhard Oct 2, 2019
d779406
Update build.gradle
sridhardvvce Oct 3, 2019
fe17505
Update react-native-video.podspec
sridhardvvce Oct 3, 2019
e209533
Update react-native-video.podspec
sridhardvvce Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,10 @@ export default class Video extends Component {
};

_onReadyForDisplay = (event) => {
this._hidePoster();
if (!this.props.audioOnly) {
this._hidePoster();
}

if (this.props.onReadyForDisplay) {
this.props.onReadyForDisplay(event.nativeEvent);
}
Expand Down
4 changes: 2 additions & 2 deletions android-exoplayer/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ android {

dependencies {
implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
implementation('com.google.android.exoplayer:exoplayer:2.10.4') {
implementation('com.google.android.exoplayer:exoplayer:2.10.5') {
exclude group: 'com.android.support'
}

Expand All @@ -32,7 +32,7 @@ dependencies {
implementation "androidx.core:core:1.1.0"
implementation "androidx.media:media:1.1.0"

implementation('com.google.android.exoplayer:extension-okhttp:2.10.4') {
implementation('com.google.android.exoplayer:extension-okhttp:2.10.5') {
exclude group: 'com.squareup.okhttp3', module: 'okhttp'
}
implementation 'com.squareup.okhttp3:okhttp:3.14.3'
Expand Down
4 changes: 2 additions & 2 deletions react-native-video.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ Pod::Spec.new do |s|
s.description = package['description']
s.license = package['license']
s.author = package['author']
s.homepage = 'https://github.com/brentvatne/react-native-video'
s.source = { :git => "https://github.com/brentvatne/react-native-video.git", :tag => "#{s.version}" }
s.homepage = 'https://github.com/learnyst/react-native-video'
s.source = { :git => "https://github.com/learnyst/react-native-video.git", :tag => "#{s.version}" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this for the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not just change to https://github.com/react-native-community/react-native-video? Don't know why brentvatne is still there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we need to change...I will change it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea when this fix will be complete?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Any idea when a new release that includes this fix will be made available?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, My group at work is using react-native-video in one of our apps and this issue is currently one of the blockers keeping us from releasing. Would you be able to provide an ETA on when the next version that includes this fix will be released?


s.ios.deployment_target = "8.0"
s.tvos.deployment_target = "9.0"
Expand Down