Skip to content

Commit

Permalink
Exoplayer: Use okhttp version specified in gradle.properties (#2340)
Browse files Browse the repository at this point in the history
Because React Native uses okhttp, including exoplayer causes apps to use two different versions of okhttp.  This results in some unpredictable behavior.  Clients of `react-native-video` should be able to specify the same OKHTTP version to react-native and react-native video.

See where it's specified in react-native trunk: 
- https://github.com/facebook/react-native/blob/master/ReactAndroid/gradle.properties#L15
- https://github.com/facebook/react-native/blob/e1b6cd3f756aa034b11af6bf9960efb42bde8692/ReactAndroid/build.gradle#L452-L453
  • Loading branch information
wildseansy authored Apr 8, 2021
1 parent edf0e27 commit 3dc607c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android-exoplayer/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ dependencies {
implementation('com.google.android.exoplayer:extension-okhttp:2.11.4') {
exclude group: 'com.squareup.okhttp3', module: 'okhttp'
}
implementation 'com.squareup.okhttp3:okhttp:3.14.3'
implementation 'com.squareup.okhttp3:okhttp:${OKHTTP_VERSION}'

}

1 comment on commit 3dc607c

@HatCloud
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It looks like you are trying to substitute a version variable, but using single quotes ('). For Groovy string interpolation you must use double quotes (")." from IDE lint

Please sign in to comment.