Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#90 Context 및 커스텀 훅 이름 변경 #92

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Refactor/#90 Context 및 커스텀 훅 이름 변경 #92

merged 8 commits into from
Aug 14, 2023

Conversation

navyjeongs
Copy link
Member

🤠 개요

💫 설명

  • 현재 각 채널별로 마지막에 방문한 BoardId를 저장하는 Context가 있는데 이름이 ChannelContext와 useBoardIDLists였는데 Feat: 채널 목록 전역 상태관리 #82 에서 작업하는 채널 전역 상태와 이름이 헷갈릴 것 같아서 LastVisitedBoardLists라는 이름으로 바꿨어요.
  • 이름을 바꾼 사항말고 기능 변경사항은 없어요!

📷 스크린샷 (Optional)

@navyjeongs navyjeongs added the 🧑‍🔧 Refactor 코드 리팩토링 label Aug 14, 2023
@navyjeongs navyjeongs self-assigned this Aug 14, 2023
@navyjeongs navyjeongs linked an issue Aug 14, 2023 that may be closed by this pull request
Refactor: Context 및 hook 이름 변경 #90
Closed
1 task
@navyjeongs navyjeongs closed this Aug 14, 2023
@navyjeongs navyjeongs deleted the Refactor/#90 branch August 14, 2023 07:52
@navyjeongs navyjeongs restored the Refactor/#90 branch August 14, 2023 07:53
@navyjeongs navyjeongs reopened this Aug 14, 2023
pp449
pp449 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍Context 이름이 훨씬 직관적인거 같아서 좋아요

@navyjeongs navyjeongs merged commit 5f362ff into dev Aug 14, 2023
@navyjeongs navyjeongs deleted the Refactor/#90 branch August 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp449 pp449 pp449 approved these changes

Assignees

@navyjeongs navyjeongs

Labels
🧑‍🔧 Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Context 및 hook 이름 변경
2 participants
@navyjeongs @pp449