Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#214 로딩 컴포넌트 생성 및 layout에 적용 #217

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

navyjeongs
Copy link
Member

@navyjeongs navyjeongs commented Nov 5, 2023

🤠 개요

💫 설명

우선 최초에 로그인 여부를 판단할 때 사용하려고 background를 main.png를 사용했어요. 추후에 많은 곳에서 사용하려고 하면 Props로 background url을 받거나 이미지를 로딩 컴포넌트에서 제거해야할 것 같아요

📷 스크린샷 (Optional)

ㅇㅇㅇ

@navyjeongs navyjeongs requested a review from pp449 November 5, 2023 07:36
@navyjeongs navyjeongs self-assigned this Nov 5, 2023
@navyjeongs navyjeongs linked an issue Nov 5, 2023 that may be closed by this pull request
1 task
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM~

@navyjeongs navyjeongs merged commit 3ec179c into dev Nov 15, 2023
@navyjeongs navyjeongs deleted the Feat/#214 branch November 15, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: 로딩 컴포넌트 생성
2 participants