Optimize Application Server worker pools #4607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4606
Changes
pkg/workerpool
, which contains the generic worker pool that spawns workers on demandpkg/workerpool
pool instead of the manually spawned tasksio.Subscription
and the actual worker pools of each package. This is intentional and allows us to decide to which package we need to send a particular uplink to in parallel.pkg/workerpool
pool instead of the manually spawned goroutinesTesting
Unit testing and local testing.
Regressions
This changes the piping used by the Application Server worker pools. The unit tests cover this.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.