Skip to content

Change: China War Factory door time from 4000 to 3300 ms #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Jul 29, 2022

Relates to

This change reduces China Warfactory door times. It equals USA Warfactory door times.

Object DoorOpeningTime DoorWaitOpenTime DoorCloseTime
Original USA Warfactory 3250 3000 4000
Patched USA Warfactory 3300 3000 3300
Original China Warfactory 4000 2000 5000
Patched China Warfactory (this) 3300 3000 3300

This enables China to build all vehicles 700 ms, 21 frames, quicker.
The door animation duration has been set to 99 frames to match the 3300 ms properly.

Rationale

Factory door time is added on top of production time. This means when a vehicle shows ready in the production queue, it takes the door to fully open until the vehicle can spawn. The original 4 seconds make this an awfully long experience compared to USA and GLA. On top of that the visuals show the door open for 2 seconds until the vehicle finally spawns, which makes the wait more painful to anticipate, as the vehicle does not spawn after the door stopped moving, unlike it does with USA and GLA factories (See first video below).

Reducing the door time and adjusting the animation for the duration of new time will make the behaviour consistent with USA. It makes the machanic easier to anticipate and learn cross factions, and a more pleasant experience in practice.

Inherently this makes all China factions produce vehicles quicker. This can be desirable, because China is often the faction under early pressure against both GLA and USA. If vehicles produce too quickly because of it, it is advised to revisit vehicle build times.

Original

china_wf_original.mp4

Patched

china_wf_patch.mp4

@xezon xezon added Design Is a matter of game design Controversial Is controversial Major Severity: Minor < Major < Critical < Blocker labels Jul 29, 2022
@Jundiyy
Copy link
Collaborator

Jundiyy commented Jul 29, 2022

Seems good.

@xezon xezon force-pushed the door-fix-china-wf branch from 8d43951 to 98ef221 Compare July 30, 2022 14:31
@xezon xezon merged commit e0342d7 into main Jul 30, 2022
@xezon xezon deleted the door-fix-china-wf branch July 30, 2022 14:32
@xezon xezon added the Bug Something is not working right label Nov 2, 2022
@ImTimK ImTimK added China Affects China faction Buff Makes a thing more powerful labels Nov 6, 2022
@xezon xezon changed the title Change China War Factory door time from 4000 to 3300 ms Change: China War Factory door time from 4000 to 3300 ms Mar 19, 2023
@commy2 commy2 mentioned this pull request Aug 1, 2023
@xezon xezon added the GameMismatchWith104 Affects game state towards original 1.04 label Mar 3, 2025
@ImTimK
Copy link
Collaborator

ImTimK commented Mar 16, 2025

Revisiting this, to start with, could we compensate China WF production times, so it doesn't affect balance? It just makes things less much less complicated.

@xezon
Copy link
Contributor Author

xezon commented Mar 16, 2025

I read the opening rationale text and I still agree with what I wrote back then.

Inherently this makes all China factions produce vehicles quicker. This can be desirable, because China is often the faction under early pressure against both GLA and USA. If vehicles produce too quickly because of it, it is advised to revisit vehicle build times.

I would recommend to slap + 700 ms on every vehicle instead of making the doors slower again. This way door times can keep this setup (and be consistent with USA) but vehicles practically build in same time.

@ImTimK
Copy link
Collaborator

ImTimK commented Mar 16, 2025

Yes, that was the suggestion indeed.

@ImTimK
Copy link
Collaborator

ImTimK commented Mar 17, 2025

I will go through the ini files later and upload it here

@xezon
Copy link
Contributor Author

xezon commented Mar 17, 2025

You need to create a pull request. We cannot work with zip files.

@ImTimK
Copy link
Collaborator

ImTimK commented Mar 17, 2025

Oh like a separate one? Thought it'd be better to combine the files/edits with this commit.

@xezon
Copy link
Contributor Author

xezon commented Mar 17, 2025

This change is already merged into main branch. You need to create a new branch with your new changes.

@ImTimK
Copy link
Collaborator

ImTimK commented Mar 17, 2025

Ok, will do, I didn't know you couldn't edit merged commits.

@xezon
Copy link
Contributor Author

xezon commented Mar 23, 2025

Jundiyy rightfully raised that adding 700 ms to unit production times is not equivalent to counter this change, because the production time is affected by Power whereas the door time is not.

This means the door time would have to be increased again to restore the status quo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Bug Something is not working right China Affects China faction Controversial Is controversial Design Is a matter of game design GameMismatchWith104 Affects game state towards original 1.04 Major Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants