-
Notifications
You must be signed in to change notification settings - Fork 39
Change: China War Factory door time from 4000 to 3300 ms #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems good. |
Revisiting this, to start with, could we compensate China WF production times, so it doesn't affect balance? It just makes things less much less complicated. |
I read the opening rationale text and I still agree with what I wrote back then.
I would recommend to slap + 700 ms on every vehicle instead of making the doors slower again. This way door times can keep this setup (and be consistent with USA) but vehicles practically build in same time. |
Yes, that was the suggestion indeed. |
I will go through the ini files later and upload it here |
You need to create a pull request. We cannot work with zip files. |
Oh like a separate one? Thought it'd be better to combine the files/edits with this commit. |
This change is already merged into main branch. You need to create a new branch with your new changes. |
Ok, will do, I didn't know you couldn't edit merged commits. |
Jundiyy rightfully raised that adding 700 ms to unit production times is not equivalent to counter this change, because the production time is affected by Power whereas the door time is not. This means the door time would have to be increased again to restore the status quo. |
Relates to
This change reduces China Warfactory door times. It equals USA Warfactory door times.
This enables China to build all vehicles 700 ms, 21 frames, quicker.
The door animation duration has been set to 99 frames to match the 3300 ms properly.
Rationale
Factory door time is added on top of production time. This means when a vehicle shows ready in the production queue, it takes the door to fully open until the vehicle can spawn. The original 4 seconds make this an awfully long experience compared to USA and GLA. On top of that the visuals show the door open for 2 seconds until the vehicle finally spawns, which makes the wait more painful to anticipate, as the vehicle does not spawn after the door stopped moving, unlike it does with USA and GLA factories (See first video below).
Reducing the door time and adjusting the animation for the duration of new time will make the behaviour consistent with USA. It makes the machanic easier to anticipate and learn cross factions, and a more pleasant experience in practice.
Inherently this makes all China factions produce vehicles quicker. This can be desirable, because China is often the faction under early pressure against both GLA and USA. If vehicles produce too quickly because of it, it is advised to revisit vehicle build times.
Original
china_wf_original.mp4
Patched
china_wf_patch.mp4