Skip to content

Fix: Reinforcement Pad Is Deleted When Destroyed; It And Repair Bay Do Not Leave Ruins Like Other Tech Buildings #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Oct 16, 2021

ZH 1.04

destroyed-reinforcement-pad.mp4

After patch:

destroyed-reinforcement-pad-fixed.mp4

This happens because while all tech buildings have a KeepObjectDie module that is supposed to spawn a ruin, the Reinforcement Pad only has a conflicting DestroyDie module as well that deletes the building when destroyed.

This also applies to the unused Repair Pad (not to be confused with the Repair Station), which is also fixed by this PR.

@commy2 commy2 added the Bug Something is not working right label Oct 16, 2021
@Jundiyy
Copy link
Collaborator

Jundiyy commented Oct 16, 2021

👍

@xezon
Copy link
Contributor

xezon commented Oct 16, 2021

Hmm. This does not look proper. Killing Tech building leaves a relatively flat model. Here it looks almost as if it is still alive and could be repaired. It can cause user confusion. It would fine if it looked like the other tech buildings.

shot_20211016_154713_3

@commy2
Copy link
Collaborator Author

commy2 commented Oct 16, 2021

Compare it with the Repair Bay.

@xezon
Copy link
Contributor

xezon commented Oct 16, 2021

Which map is that?

@commy2
Copy link
Collaborator Author

commy2 commented Oct 16, 2021

Cairo Commandos (3) comes to mind. Has both in center (as well as some oils).

@xezon
Copy link
Contributor

xezon commented Oct 16, 2021

I see. The Repair Bay has the same behavior as this change. By this standard the change would be ok. I wonder if it was possible to make a follow up change where these building would spawn a different model, similar style to Oil Refinery. Maybe Enlima29 already has something like that in NProject Mod ready for grabs.

shot_20211016_172549_1
.

@commy2
Copy link
Collaborator Author

commy2 commented Oct 16, 2021

That would be preferable, since the destroyed Repair Bay can indeed be confusing. We'd need the assets for that though, no such model exists.

@commy2 commy2 added the OngoingDiscussion Requires further discussion label Oct 16, 2021
@alanblack166
Copy link
Contributor

Shockwave/Rise of the Reds has a rubble model:
image

@alanblack166
Copy link
Contributor

Also for Reinforcement Pad:
image

@xezon
Copy link
Contributor

xezon commented Oct 16, 2021

That looks much better!

@commy2
Copy link
Collaborator Author

commy2 commented Oct 16, 2021

Very good. But who made them and are we allowed to use them?

@alanblack166
Copy link
Contributor

alanblack166 commented Oct 16, 2021

Those exist in the game already:
ZBLndBay_R
ZBLndBay_RS
ZBRprBay_R
ZBRprBay_RS

@commy2
Copy link
Collaborator Author

commy2 commented Oct 16, 2021

Thank you for the tip. I implemented those models in this branch, and I think they look awesome.

@commy2 commy2 removed the OngoingDiscussion Requires further discussion label Oct 17, 2021
@Jundiyy
Copy link
Collaborator

Jundiyy commented Oct 17, 2021

Looks great.

@commy2 commy2 merged commit 97d08bc into main Oct 17, 2021
@commy2 commy2 deleted the fix-disappearing-tech-building-ruins branch October 17, 2021 11:53
@commy2 commy2 changed the title Fix: Reinforcement Pad Is Deleted When Destroyed; Does Not Leave Ruin Like Other Tech Buildings Fix: Reinforcement Pad Is Deleted When Destroyed; It And Repair Bay Do Not Leave Ruins Like Other Tech Buildings Oct 17, 2021
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Art Is art related Civilian Affects Civilian faction labels Mar 18, 2023
@xezon xezon added the GameMismatchWith104 Affects game state towards original 1.04 label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related Bug Something is not working right Civilian Affects Civilian faction GameMismatchWith104 Affects game state towards original 1.04 Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants