-
Notifications
You must be signed in to change notification settings - Fork 39
Fix: Reinforcement Pad Is Deleted When Destroyed; It And Repair Bay Do Not Leave Ruins Like Other Tech Buildings #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Like Other Tech Buildings
👍 |
Compare it with the Repair Bay. |
Which map is that? |
Cairo Commandos (3) comes to mind. Has both in center (as well as some oils). |
I see. The Repair Bay has the same behavior as this change. By this standard the change would be ok. I wonder if it was possible to make a follow up change where these building would spawn a different model, similar style to Oil Refinery. Maybe Enlima29 already has something like that in NProject Mod ready for grabs. |
That would be preferable, since the destroyed Repair Bay can indeed be confusing. We'd need the assets for that though, no such model exists. |
That looks much better! |
Very good. But who made them and are we allowed to use them? |
Those exist in the game already: |
Thank you for the tip. I implemented those models in this branch, and I think they look awesome. |
Looks great. |
ZH 1.04
destroyed-reinforcement-pad.mp4
After patch:
destroyed-reinforcement-pad-fixed.mp4
This happens because while all tech buildings have a
KeepObjectDie
module that is supposed to spawn a ruin, the Reinforcement Pad only has a conflictingDestroyDie
module as well that deletes the building when destroyed.This also applies to the unused Repair Pad (not to be confused with the Repair Station), which is also fixed by this PR.