Skip to content

Fix: cbgpub02 textures #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2024
Merged

Fix: cbgpub02 textures #2447

merged 2 commits into from
Jul 21, 2024

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Jul 20, 2024 •
edited
Loading

This change fixes Civilian cbgpub02 textures.

cbgpub02

  • Fixes misshaped house windows
  • Fixes misplaced and blurry window reflections

cbgpub02_d, cbgpub02_g, cbgpub02_dg

  • Fixes misshaped house windows
  • Fixes too strong window reflections

cbgpub02_e, cbgpub02_r

  • Fixes misshaped house windows
  • Adds additional damages to alpha channel

cbgpub02_s

  • Fixes snow position mismatches with cbgpub02_ds, cbgpub02_sg
  • Fixes too dark snow patches
  • Fixes misshaped house windows
  • Fixes misplaced and blurry window reflections

cbgpub02_ds, cbgpub02_sg, cbgpub02_dsg

  • Fixes too dark snow patches
  • Fixes misshaped house windows
  • Fixes too strong window reflections

cbgpub02_es, cbgpub02_rs

  • Fixes snow inconsistencies with cbgpub02_ds
  • Fixes too dark snow patches
  • Fixes misshaped house windows
  • Adds additional damages to alpha channel

cbgpub02_n, cbgpub02_ng

  • Fixes light artifacts

cbgpub02_dn

  • Fixes light artifacts
  • Removes superfluous alpha channel

cbgpub02_dng

  • Fixes light mismatches with cbgpub02_dn
  • Fixes light artifacts

cbgpub02_en, cbgpub02_esn

  • Fixes incorrect night light

cbgpub02_rn, cbgpub02_rsn

  • Optimizes texture size

TODO

  • CBGPUB02_s.w3d is missing window reflections

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content Art Is art related Civilian Affects Civilian faction labels Jul 20, 2024
@xezon
Copy link
Contributor Author

xezon commented Jul 21, 2024

Looks good.

@xezon xezon merged commit 41bfe21 into main Jul 21, 2024
@xezon xezon deleted the texture-cbgpub02 branch July 21, 2024 07:26
lavaboat pushed a commit to lavaboat/GeneralsGamePatch that referenced this pull request Mar 19, 2025
@xezon
Fix: cbgpub02 textures (TheSuperHackers#2447)
bc42b60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Art Is art related Civilian Affects Civilian faction Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xezon