Skip to content

Fix: cbeurocnd textures #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2024
Merged

Fix: cbeurocnd textures #2430

merged 3 commits into from
Jun 23, 2024

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Jun 23, 2024 •
edited
Loading

This change fixes cbeurocnd textures

cbeurocnd_dg

  • Fixes window reflections over window damages

cbeurocnd_e, cbeurocnd_r, cbeurocnd_es, cbeurocnd_rs

  • Fixes floating pixels in alpha channel

cbeurocnd_s

  • Fixes minor snow discrepancies with cbeurocnd_sg
  • Fixes missing snow on window reflections

cbeurocnd_ds

  • Fixes minor snow discrepancies with cbeurocnd_dsg
  • Fixes shadows on ground floor

cbeurocnd_sg

  • Fixes missing snow on window reflections

cbeurocnd_dsg

  • Fixes shadows on ground floor
  • Fixes error on window reflections

cbeurocnd_n

  • Removes superfluous alpha channel

cbeurocnd_dn, cbeurocnd_dng, cbeurocnd_dsn, cbeurocnd_dsng

  • Fixes faint night light artifacts

cbeurocnd_en, cbeurocnd_rn, cbeurocnd_esn, cbeurocnd_rsn

  • Optimizes texture size

TODO

  • CBEUROCND_ESN.w3d uses non-snow textures
  • CBEUROCND_RN.w3d, CBEUROCND_RS.w3d, CBEUROCND_RSN.w3d are missing alpha draw on damages

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content Art Is art related Civilian Affects Civilian faction labels Jun 23, 2024
@xezon xezon force-pushed the texture-cbeurocnd branch from 91bdd2a to 4aadc4f Compare June 23, 2024 05:09
@xezon
Copy link
Contributor Author

xezon commented Jun 23, 2024

Looks good.

@xezon xezon merged commit 9013899 into main Jun 23, 2024
@xezon xezon deleted the texture-cbeurocnd branch June 23, 2024 05:47
lavaboat pushed a commit to lavaboat/GeneralsGamePatch that referenced this pull request Mar 19, 2025
@xezon
Fix: cbeurocnd textures (TheSuperHackers#2430)
a2f6010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Art Is art related Civilian Affects Civilian faction Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xezon