Skip to content

Fix: Listening Outpost headlights barely visible from some angles, turned on while stationary #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 5, 2023

This pull request fixes a model issue that causes the headlight to be barely visible when viewed from some angles.

before from right (correct)

https://user-images.githubusercontent.com/6576312/258529955-3d34ba8d-5e5e-4a10-8a44-6d7789fba2f8.jpg

before from left (broken)

https://user-images.githubusercontent.com/6576312/258529760-3b88e0e9-f453-49d5-942d-0ef8c3732740.jpg

after from left (working)

https://user-images.githubusercontent.com/6576312/258529742-36765c02-dab8-40dc-9e4e-8c8fb917a18d.jpg

no change after from right

  • This pull request also changes the headlight when stationary. It logically makes no sense for a stealthed vehicle to have the lights turned on at night. Therefore, with this PR, the Outpost now turns off the lights when parked:
randomlights.mp4

This includes some randomization to make it look properly when mass moving Outposts.

@commy2 commy2 added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Art Is art related China Affects China faction labels Aug 5, 2023
@commy2 commy2 self-assigned this Aug 5, 2023
@xezon
Copy link
Contributor

xezon commented Aug 5, 2023

May I suggest to apply the new lamps toggle separately, together with the sentry drone?

@commy2
Copy link
Collaborator Author

commy2 commented Aug 5, 2023

I think I will fix each individually, or maybe some in batches like all the Vee variants.

Fixing headlights first, then adding the light toggle wouldn't work for Outpost, as both require mutually exclusive model setups (bone name HEADLIGHT is hard-coded to turn on/off depending on time of day and ignored manual override).

@xezon
Copy link
Contributor

xezon commented Aug 5, 2023

Ok. How do we want to document lamp fixes?

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs documentation. I suggest merge documentation with 261_outpost_smoke_effect.yaml

@commy2 commy2 merged commit b23ca96 into main Aug 6, 2023
@commy2 commy2 deleted the fix-headlight branch August 6, 2023 07:11
@commy2 commy2 removed their assignment Aug 6, 2023
@ItsWazzaP ItsWazzaP added the GameMismatchWith104 Affects game state towards original 1.04 label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related Bug Something is not working right China Affects China faction GameMismatchWith104 Affects game state towards original 1.04 Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants