Skip to content

Fix: Key mapping mismatches between faction unit variations #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Jul 23, 2023

This change fixes all key mapping mismatches between faction unit variations. This greatly reduces the complexity of key mappings one has to remember. The key mapping of the regular faction unit typically takes precedence.

  • The China Hacker can now be produced with the same key as for the Super Hacker in German language.
  • The China Emperor can now be produced with the same key as for the Overlord in French, Polish languages.
  • The China Minigunner can now be produced with the same key as for the regular Red Guard in all languages.
  • The China Super Lotus can now be produced with the same key as for the regular Black Lotus in all language.
  • The China Attack Outpost can now be produced with the same key as for the regular Outpost in English, Spanish, Italian, Korean, Chinese, Brazilian, Polish languages.
  • The China Assault Troop Crawler can now be produced with the same key as for the regular Troop Crawler in English, French, Spanish, Italian, Korean, Chinese, Brazilian, Polish languages.
  • The China Fortified Bunker can now be constructed with the same key as for the regular Bunker in Polish language.
  • The China Nuke Bomber can now be placed with the same key as for the regular Bomber in English, Korean, Chinese languages.
  • The GLA Toxin Rebel can now be produced with the same key as for the regular Rebel in German language.
  • The GLA Toxin Terrorist can now be produced with the same key as for the regular Terrorist in Spanish language.
  • The USA Control Rods can now be researched with the same key as for the Advanced Control Rods in Polish language.
  • The USA Aurora Alpha can now be produced with the same key as for the regular Aurora in Spanish, Italian languages.
  • The USA King Raptor can now be produced with the same key as for the regular Raptor in Brazilian language.
  • The USA Laser Turret can now be constructed with the same key as for the regular Patriot Battery in English, Spanish, Korean, Chinese, Brazilian, Polish languages.
  • The USA Laser Crusader can now be produced with the same key as for the regular Crusader in English, Korean, Chinese, Brazilian, Polish languages.

Inspected button texts

SWG

CONTROLBAR:UpgradeAmericaAdvancedControlRods [FIXED]
CONTROLBAR:SupW_UpgradeAmericaAdvancedControlRods [GOOD]
CONTROLBAR:SupW_ConstructAmericaPatriotBattery [GOOD]
CONTROLBAR:ConstructAmericaJetFuelAirAurora [FIXED]

LASER

CONTROLBAR:Lazr_ConstructAmericaPatriotBattery [FIXED]
CONTROLBAR:Lazr_ConstructAmericaTankCrusader [FIXED]

AIRFORCE

CONTROLBAR:AirF_ConstructAmericaVehicleChinook [GOOD]
CONTROLBAR:ConstructAmericaJetKingRaptor [FIXED]

DEMO

CONTROLBAR:Demo_ConstructGLADemoTrap [GOOD]

CHEMICAL

CONTROLBAR:Chem_ConstructGLAInfantryRebel [FIXED]
CONTROLBAR:Chem_ConstructGLAInfantryTerrorist [FIXED]
CONTROLBAR:Chem_ConstructGLATunnelNetwork [GOOD]

STEALTH

CONTROLBAR:Slth_ConstructGLAInfantryRebel [GOOD]

TANK

CONTROLBAR:ConstructChinaTankEmperor [FIXED]

NUKE

CONTROLBAR:Nuke_ConstructChinaTankOverlord [GOOD]
CONTROLBAR:Nuke_ConstructChinaTankBattleMaster [GOOD]
CONTROLBAR:Nuke_ConstructChinaVehicleListeningOutpost [FIXED]
CONTROLBAR:Nuke_ConstructChinaPowerPlant [GOOD]
CONTROLBAR:Nuke_CarpetBomb [FIXED]
CONTROLBAR:ConstructChinaInfantryNukeHunter [FIXED]

INFANTRY

CONTROLBAR:ConstructChinaInfantryHacker [FIXED]
CONTROLBAR:Infa_ConstructChinaInfantryHacker [GOOD]
CONTROLBAR:Infa_ConstructChinaInfantryBlackLotus [FIXED]
CONTROLBAR:Infa_ConstructChinaVehicleListeningOutpost [FIXED]
CONTROLBAR:Infa_ConstructChinaVehicleTroopCrawler [FIXED]
CONTROLBAR:Infa_ConstructChinaVehicleHelix [GOOD]
CONTROLBAR:Infa_ConstructChinaBunker [FIXED]
CONTROLBAR:ConstructChinaInfantryMiniGunner [FIXED]

@xezon xezon added Major Severity: Minor < Major < Critical < Blocker USA Affects USA faction China Affects China faction GLA Affects GLA faction Text Is text, string, localization related Design Is a matter of game design labels Jul 23, 2023
@xezon xezon force-pushed the text-faction-variant-key-mappings branch from 95fb4d6 to e502af5 Compare July 23, 2023 14:54
@xezon
Copy link
Contributor Author

xezon commented Jul 23, 2023

Fixed King Raptor key mismatches. Documentation added.

@xezon xezon force-pushed the text-faction-variant-key-mappings branch 2 times, most recently from 607c4fa to 2a72ce5 Compare August 13, 2023 10:59
@xezon xezon force-pushed the text-faction-variant-key-mappings branch from 2a72ce5 to 8158bdb Compare August 13, 2023 11:03
@xezon xezon merged commit d83a70e into main Aug 13, 2023
@xezon xezon deleted the text-faction-variant-key-mappings branch August 13, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
China Affects China faction Design Is a matter of game design GLA Affects GLA faction Major Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant