Optimization: Decrease cost of toxin and hazard cleanup stream trail particles by around 50% #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Major
xezon
added a commit
that referenced
this pull request
Jun 24, 2023
xezon
added a commit
that referenced
this pull request
Jun 24, 2023
xezon
force-pushed
the
optimize-stream-particles
branch
from
cb26050 to
61bcfbf
Compare
|
Can't spot the difference :) |
|
Looks very good indeed |
xezon
added a commit
that referenced
this pull request
Jun 24, 2023
xezon
added a commit
that referenced
this pull request
Jun 24, 2023
xezon
force-pushed
the
optimize-stream-particles
branch
from
61bcfbf to
43af148
Compare
xezon
force-pushed
the
optimize-stream-particles
branch
from
43af148 to
e5a3807
Compare
xezon
changed the title
xezon
changed the title
xezon
changed the title
|
I have reviewed changes and reverted some optimizations to compromise less on the visual quality. Performance cost is reduced by 50% to 65%. Toxin trails look almost identical thanks to a trick. Documentation added. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change decreases the cost of toxin and hazard cleanup stream trail particles by around 50%. The overall performance improvement of the stream weapon is significantly less than that, because there are other expensive components.
Affects
Before
Expensive stream particle effects.
generals.2023-06-24.09-21-28-72_ORIGINAL.mp4
After (Outdated)
The original look was preserved as much as possible. At a glance the effects look very similar.
generals.2023-06-24.09-45-18-24.mp4