Skip to content

Fix: Remove duplicate sounds in audio events #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2023
Merged

Fix: Remove duplicate sounds in audio events #1926

merged 1 commit into from
May 20, 2023

Conversation

xezon
Copy link
Contributor

@xezon xezon commented May 8, 2023 •
edited
Loading

This change removes duplicate sounds in audio events:

  • CrowdPanic
  • CrowdPanicLong
  • HumveeMoveStart
  • Amb_UrbanChinaCourtyardBirds
  • ComancheVoiceAttackRocket
  • MigVoiceFalling
  • JarmenKellVoiceFear

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Audio Is audio related labels May 8, 2023
@xezon xezon changed the title Fix: Remove duplicate sound in CrowdPanic, CrowdPanicLong Fix: Remove duplicate sounds in audio events May 20, 2023
@xezon
Copy link
Contributor Author

xezon commented May 20, 2023

I used script to find audio events with duplicate sounds. They are

CrowdPanic [fixed]
CrowdPanicLong [fixed]
BuildingImpactLight [discard]
GenericFireLargeLoop [discard]
GenericFireMediumLoop [discard]
ExplosionBattleshipTarget [discard]
HumveeMoveStart [fixed]
Amb_DesertVillageDayWallaLoop [discard]
Amb_UrbanCityAmbientLoop [discard]
Amb_UrbanCityAmbientLoop2 [fixed]
Amb_UrbanDocksMachineryLoop [discard]
Amb_DesertMarketWallaLoop2 [discard]
Amb_DesertMarketWallaLoop3 [discard]
Amb_UrbanChinaCourtyardBirds [fixed]
AmbientArabMarket2 [discard]
AvalancheTextureLoop [discard]
ComancheVoiceAttackRocket [fixed]
MigVoiceFalling [fixed]
CINE_U03_BlackLotusVoiceModeBuilding [discard]
JarmenKellVoiceFear [fixed]

I reviewed all of them and applied additional fixed to this pull. Most of the duplicates I have left untouched, because they make sense.

@xezon xezon force-pushed the sounds-panic-crowd branch from bd4e3a2 to a73e2e1 Compare May 20, 2023 07:50
@xezon
Copy link
Contributor Author

xezon commented May 20, 2023

Documentation added. Looks good.

@xezon xezon force-pushed the sounds-panic-crowd branch from a73e2e1 to e754502 Compare May 20, 2023 07:54
@xezon xezon merged commit 75f7e89 into main May 20, 2023
@xezon xezon deleted the sounds-panic-crowd branch May 20, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Audio Is audio related Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xezon