Skip to content

Change: Add new cursor for ground force attack #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

xezon
Copy link
Contributor

@xezon xezon commented May 3, 2023

This change adds a new cursor for ground force attack. This way there is a clear distinction between force attack object and force attack ground, which are conceptually different, because a ground attack does not follow an object.

Original attack cursor:

sccattack

Patched ground force attack cursor:

SCCAttack3

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Art Is art related labels May 3, 2023
@xezon xezon force-pushed the add-force-attack-cursor branch from fa87a47 to 77d1e06 Compare May 3, 2023 18:42
@ImTimK
Copy link
Collaborator

ImTimK commented May 3, 2023

Good little improvement I think, why not?

@xezon
Copy link
Contributor Author

xezon commented May 4, 2023

The only problem I have that this perhaps is too little of a distinction for color blind people. Shades of Red and Orange may look very similar. I tried to decorate the arrows differently on top of the color change, but did not come up with a good variant.

@MTKing4
Copy link
Collaborator

MTKing4 commented May 4, 2023

I do think a design change is better than a color change, i mean this color can be difficult to tell apart even for normal sighted people at certain angles and different monitor types

@xezon
Copy link
Contributor Author

xezon commented May 4, 2023

Options:

  • Make arrows black border thicker
  • Spawn a small growing ring from the center when the arrows meet
  • Draw 4 long vertical lines from the center when the arrows meet

@ImTimK
Copy link
Collaborator

ImTimK commented May 4, 2023

perhaps rotate cursor 45 degrees?

@xezon
Copy link
Contributor Author

xezon commented May 4, 2023

perhaps rotate cursor 45 degrees?

Then it would look more similar to the green move cursor, which is vertical like that. I do not think that fits.

@ImTimK
Copy link
Collaborator

ImTimK commented May 4, 2023

Or just make the orange slightly brighter for better contrast with the red one.

@MTKing4
Copy link
Collaborator

MTKing4 commented May 4, 2023

Options:

  • Make arrows black border thicker
  • Spawn a small growing ring from the center when the arrows meet
  • Draw 4 long vertical lines from the center when the arrows meet

Second Option Sounds nice, could be just a static one, no need to regrow, think it would look better that way

4 Vertical lines? How's that supposed to look?

@xezon
Copy link
Contributor Author

xezon commented May 4, 2023

4 Vertical lines? How's that supposed to look?

Here is a potential candidate. Basically the yellow impact thingy in the middle expands further away from the center, so it looks more distinct from the original, but is overall still the same cursor style.

SCCAttack7 SCCAttack7

Reference cursors:

SCCAttack1 sccattack

SCCAttack3 SCCAttack3

@xezon xezon force-pushed the add-force-attack-cursor branch from 77d1e06 to a492485 Compare May 4, 2023 19:33
@xezon
Copy link
Contributor Author

xezon commented May 4, 2023

I tested SCCAttack7 in game and it looked nice. Looks sufficiently different I think. Change updated.

@MTKing4
Copy link
Collaborator

MTKing4 commented May 4, 2023

I was confused by the fact you said vertical, but i guess you meant diagonal :P

Looks good

@xezon
Copy link
Contributor Author

xezon commented May 10, 2023

Fix TheSuperHackers/GeneralsModBuilder#30 before merge.

@xezon xezon force-pushed the add-force-attack-cursor branch from a492485 to b867cf5 Compare June 11, 2023 10:47
@xezon xezon force-pushed the add-force-attack-cursor branch from b867cf5 to c1e5b5c Compare June 21, 2023 19:47
@xezon
Copy link
Contributor Author

xezon commented Jun 21, 2023

TheSuperHackers/GeneralsModBuilder#30 has been fixed. Cursor install and uninstall works properly. Documentation added. Looks good.

@xezon xezon merged commit 440093e into main Jun 21, 2023
@xezon xezon deleted the add-force-attack-cursor branch June 21, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants