-
Notifications
You must be signed in to change notification settings - Fork 39
Change: Add new cursor for ground force attack #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa87a47
to
77d1e06
Compare
Good little improvement I think, why not? |
The only problem I have that this perhaps is too little of a distinction for color blind people. Shades of Red and Orange may look very similar. I tried to decorate the arrows differently on top of the color change, but did not come up with a good variant. |
I do think a design change is better than a color change, i mean this color can be difficult to tell apart even for normal sighted people at certain angles and different monitor types |
Options:
|
perhaps rotate cursor 45 degrees? |
Then it would look more similar to the green move cursor, which is vertical like that. I do not think that fits. |
Or just make the orange slightly brighter for better contrast with the red one. |
Second Option Sounds nice, could be just a static one, no need to regrow, think it would look better that way 4 Vertical lines? How's that supposed to look? |
Here is a potential candidate. Basically the yellow impact thingy in the middle expands further away from the center, so it looks more distinct from the original, but is overall still the same cursor style. Reference cursors: |
77d1e06
to
a492485
Compare
I tested SCCAttack7 in game and it looked nice. Looks sufficiently different I think. Change updated. |
I was confused by the fact you said vertical, but i guess you meant diagonal :P Looks good |
Fix TheSuperHackers/GeneralsModBuilder#30 before merge. |
a492485
to
b867cf5
Compare
b867cf5
to
c1e5b5c
Compare
TheSuperHackers/GeneralsModBuilder#30 has been fixed. Cursor install and uninstall works properly. Documentation added. Looks good. |
This change adds a new cursor for ground force attack. This way there is a clear distinction between force attack object and force attack ground, which are conceptually different, because a ground attack does not follow an object.
Original attack cursor:
Patched ground force attack cursor: