Skip to content

Fix: Add Stop command button to all worker units #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Apr 30, 2023

This change adds the Stop command button to all worker units (except Boss). This way button can be pressed to stop worker units, including in group selection with other units.

To put the Stop button at its expected position, the Clear Mines, GLA Fake Structures and USA Airfield buttons had to be moved.

This change applies to the optional Patch bundle only.

Advantages

  • Stop button added
  • Clear Mines button now at same Position as Guard Mode button
  • USA Airfield button is closer to other structures, and in same row as China Airfield

Disadvantages

  • Clear Mines, GLA Fake Structures, USA Airfield buttons moved
  • GLA Fake Structures button is closer to Arms Dealer button

Patched, Before

shot_20230121_131853_1

shot_20230121_131859_3

shot_20230121_131902_4

Patched, After (This)

shot_20230121_133026_2

shot_20230121_133030_3

shot_20230121_133037_4

All regular worker units selected.

shot_20230121_132855_1

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content USA Affects USA faction China Affects China faction GLA Affects GLA faction GUI For graphical user interface Bug Something is not working right and removed Enhancement Is new feature or request labels Apr 30, 2023
@xezon xezon force-pushed the commandset-worker-stop-2 branch from eb2e457 to 070c77a Compare April 30, 2023 08:16
@xezon
Copy link
Contributor Author

xezon commented Apr 30, 2023

Documentation added. Tested and worked. Looks good.

@xezon xezon merged commit 9530345 into main Apr 30, 2023
@xezon xezon deleted the commandset-worker-stop-2 branch April 30, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right China Affects China faction GLA Affects GLA faction GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant