Skip to content

Fix: Improve USA Alpha Aurora bomb explosion effects #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Apr 23, 2023

This is an alternative implementation for fixing and improving Alpha Aurora bomb effects. The main issues were already raised in #1751. This change addresses additional problems and avoids the down sides of #1751.

  • The initial Aurora bomb hit now shows the hit particle effects and sound. Is consistent with regular Aurora bomb hit effects.
  • The initial Aurora bomb hit no longer draws a scorch, because it is covered by the particles at the time of the impact and would be overdrawn soon after by the bigger scorch for the gas explosion. Total explosion scorch count is 1 (optimal).
  • The ignite sound effect is preserved, but is made a bit quieter than the one of the Daisy Cutter ignition, because the sparks are smaller and there is now the other explosion sound triggered at the same time.
  • The first ignition sparks are now visible earlier and spread further apart.
  • The second ignition sparks are now less in numbers and spread further apart.
  • The second ignition sparks now properly fade out.
  • The second ignition sparks now have random size.
  • The lingering green gas clouds are removed.
  • The final gas explosion is now just one explosion instance instead of 2 to 4.
  • The final gas explosion is now synced better with the actual damage and sound event.
  • The final gas explosion now has much less random size variation, so it never looks too small.
  • The original Alpha bomb shock wave effect is now a smaller copy of the Daisy Cutter shock wave.

Patched (Before)

generals.2023-04-23.14-45-04-43.mp4

Patched (This)

generals.2023-04-23.15-32-02-57.mp4

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Art Is art related USA Affects USA faction labels Apr 23, 2023
@xezon
Copy link
Contributor Author

xezon commented Apr 23, 2023

I see a problem. AirF_AuroraBombScatterIgnite2 is used in FXList Neutron_WeaponFX_NukeCannon. So that needs a copy.

And for ignite sound, perhaps we can just use the original daisy cutter sound without aurora bomb explosion sound. That way we would remove one sound from playback, aka less audio demand.

@xezon xezon force-pushed the fix-aurora-alpha-bomb-explosion-2 branch from 8c284cf to d2aac15 Compare April 23, 2023 17:34
@xezon xezon force-pushed the fix-aurora-alpha-bomb-explosion-2 branch 3 times, most recently from 7f039ed to e40b2b8 Compare May 12, 2023 16:16
@xezon xezon added the Performance Is a performance concern label May 12, 2023
@xezon xezon force-pushed the fix-aurora-alpha-bomb-explosion-2 branch from e40b2b8 to 9834696 Compare May 12, 2023 16:18
@xezon
Copy link
Contributor Author

xezon commented May 12, 2023

Added size variation for second ignition sparks like we did for Fuel Bomb and Neutron sparks. And reduced the previously added spreading of ignition sparks a bit. Documentation added. Looks good.

@xezon xezon merged commit 5f8d0cc into main May 12, 2023
@xezon xezon deleted the fix-aurora-alpha-bomb-explosion-2 branch May 12, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant