Change: Remove random sink delays from hulks of USA Ambulance, China Gattling, ECM #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Design
Stubbjax
approved these changes
Feb 10, 2023
|
lol |
commy2
approved these changes
Feb 10, 2023
|
So sink delay variance was never functional? |
First sentence. Ambulance, Gattling and ECM tank |
|
Oh, right xD |
|
Apparently no. Instead it is always added to the base value. |
|
It does work, but it cannot be configured to work well with correctly timed DestructionDelay. Adding a small variance of like 1000 ms to all hulks would be ok imo. But first step needs them all removed for proper baseline. |
|
Yes a little bit of variance will look good imo |
xezon
force-pushed
the
fix-hulk-random-sink-delays
branch
from
5650790 to
263352e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes random sink delays from hulks of USA Ambulance, China Gattling, ECM.
About Sink Delays
SinkDelayVarianceandDestructionDelayVarianceare designed a bit unfortunate.What it does:
What it should do:
(*) Apply same random generated value of variance.
Rationale
Removal of variance makes setup much easier to maintain. If we want sink variances on hulks, it should be added as last step. Only 3 original hulks have sink delay variance. Removal makes no tangible difference to visuals.