-
Notifications
You must be signed in to change notification settings - Fork 39
Fix: China Command Center Has Second Clipping Building At Night When Damaged #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The only art changed for nbconyard in NProject are these 4 textures Art\Textures\nbconyard2_d.dds |
Texture changes won't fix this. It needs model changes in |
Yes. There is no conyard model change. Just textures. |
I checked the NProject INI files. The fix is not applied there either. I think this is not fixed in NProject. A similar PR is this: #133 Instead of INI work-arounds, the model was changed. From my understanding, no HideSubObject work-around could have been applied there, because the issue was with a texture, not with rogue model parts. I think this PR is most reasonable way to fix this issue. |
77e3bf3
to
36fd6bd
Compare
36fd6bd
to
7265467
Compare
Enlima29
|
Fix looks good enough. |
before
after
Note: 'after' is essentially how the building looks already when damaged on day, snow and snow+night maps.
It may be preferable to remove the rogue objects from the model instead.