-
Notifications
You must be signed in to change notification settings - Fork 39
Fix: Improve English sound quality by removing hum, noise, hiss and crackling #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
67e9d6f
to
71f3bed
Compare
I do not think this is necessary and fear for hidden regressions when mass replacing asset files. I would rather the game sounds the same as it does now than apply any unknown tweaks. This also inflates the patch size. |
If there are issues with it, please show them. As for size, this is optional content, thus no concern for Patch Core size. |
Excellent news! I too would put this into a category like Control Bar HD / Pro. If it is optional, preferably opt-in, then I have nothing agains this being part of the project. |
The opening post does say "OptionalAudioEnglish" and the change also shows that it is bundled into optional packs. I will reword opening post so it becomes more obvious. As said in Discord: There is no way any optional fixes and improvements are getting blocked by purist opinion. As for Control Bar Pro Addon, that is complete redesign of Control Bar and thus cannot and should not be part of this project. As for these sounds, they are a direct improvement of original content and thus perfectly fit in here. Due the large bandwidth requirements it is evident that it should not be part of the core files. |
27a49bc
to
8e2a6b3
Compare
8e2a6b3
to
1627892
Compare
I made another pass on all sounds. All wav files (uncompressed) have been re-exported without meta data, saving 3.8 MB in total. All sounds have been reviewed and more clicks have been removed. Some sounds also had a bit of noise or hum left over. Additionally a few vehicle effects were fixed, most notable clicks in Helix Ambient Loops and Dragon Tank Attack, Decay. These clicks are caused if the start or end of a loop are not at 0 dB. From my side this task is now complete. |
1627892
to
a3393f7
Compare
a3393f7
to
20082b8
Compare
I did another review pass on all fixed sounds and fixed a few more things on around 60 of them. Next step for this is to split audio into smaller commit chunks to have a bit of an overview what was touched from commit. |
132913e
to
1c24b00
Compare
1c24b00
to
0bd6db2
Compare
38bf56d
to
41c6e31
Compare
41c6e31
to
04b1c41
Compare
04b1c41
to
a9fa77e
Compare
Merge with Rebase
This change fixes humming, noises, hissing and crackling for all Unit and EVA sounds. It uses 72 MB uncompressed and 58 MB 7-zip compressed. Due the large size requirement it is therefore unfit for Patch Core and will be optional content only.
The sounds are bundled into the following archives:
Affected units
USA
China
GLA