Skip to content

Fix: Improve English sound quality by removing hum, noise, hiss and crackling #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 7, 2023

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Sep 1, 2022

Merge with Rebase

This change fixes humming, noises, hissing and crackling for all Unit and EVA sounds. It uses 72 MB uncompressed and 58 MB 7-zip compressed. Due the large size requirement it is therefore unfit for Patch Core and will be optional content only.

The sounds are bundled into the following archives:

  • OptionalAudioArabic
  • OptionalAudioBrazilian
  • OptionalAudioChinese
  • OptionalAudioEnglish
  • OptionalAudioFrench (uses just a few of the sounds)
  • OptionalAudioItalian
  • OptionalAudioKorean
  • OptionalAudioPolish
  • OptionalAudioSpanish

Affected units

USA

  • Ranger
  • Laser Ranger
  • Missile Defender
  • Pathfinder
  • Burton
  • Dozer
  • Humvee
  • Ambulance
  • Crusader
  • Microwave
  • Combat Chinook
  • Comanche
  • Raptor
  • Stealth Fighter
  • Aurora
  • Spectre Gunship

China

  • Red Guard
  • Minigunner
  • China Lotus
  • Hacker
  • Dozer
  • ECM
  • Troop Crawler
  • Listening Outpost
  • Inferno Cannon
  • Nuke Cannon
  • Overlord
  • Helix

GLA

  • Worker
  • GLA Rebel
  • GLA Tunnel Defender
  • Hijacker
  • Jarmen
  • Saboteur
  • Terror
  • Car Bomb
  • Cycle
  • Toxin Tractor
  • Technical
  • Quad
  • Scorpion
  • Radar Van
  • Rocket Buggy
  • Bomb Truck
  • SCUD
  • Marauder
  • POW

@xezon xezon added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker labels Sep 1, 2022
@xezon xezon self-assigned this Sep 1, 2022
@xezon xezon changed the title Add English sounds with fixed hum, noise, hiss and crackle Fix: Improve English sound quality by removing hum, noise, hiss and crackling Sep 2, 2022
@xezon xezon force-pushed the add-clean-english-sounds branch from 67e9d6f to 71f3bed Compare September 3, 2022 07:46
@commy2
Copy link
Collaborator

commy2 commented Sep 3, 2022

I do not think this is necessary and fear for hidden regressions when mass replacing asset files. I would rather the game sounds the same as it does now than apply any unknown tweaks.

This also inflates the patch size.

@xezon
Copy link
Contributor Author

xezon commented Sep 3, 2022

If there are issues with it, please show them.

As for size, this is optional content, thus no concern for Patch Core size.

@commy2
Copy link
Collaborator

commy2 commented Sep 3, 2022

this is optional content

Excellent news! I too would put this into a category like Control Bar HD / Pro. If it is optional, preferably opt-in, then I have nothing agains this being part of the project.

@xezon
Copy link
Contributor Author

xezon commented Sep 3, 2022

The opening post does say "OptionalAudioEnglish" and the change also shows that it is bundled into optional packs. I will reword opening post so it becomes more obvious. As said in Discord: There is no way any optional fixes and improvements are getting blocked by purist opinion. As for Control Bar Pro Addon, that is complete redesign of Control Bar and thus cannot and should not be part of this project. As for these sounds, they are a direct improvement of original content and thus perfectly fit in here. Due the large bandwidth requirements it is evident that it should not be part of the core files.

@xezon xezon force-pushed the add-clean-english-sounds branch from 27a49bc to 8e2a6b3 Compare September 4, 2022 21:13
@xezon xezon added the Optional Is optional content label Sep 6, 2022
@xezon xezon force-pushed the add-clean-english-sounds branch from 8e2a6b3 to 1627892 Compare October 30, 2022 11:21
@xezon
Copy link
Contributor Author

xezon commented Oct 30, 2022

I made another pass on all sounds. All wav files (uncompressed) have been re-exported without meta data, saving 3.8 MB in total.

All sounds have been reviewed and more clicks have been removed. Some sounds also had a bit of noise or hum left over.

Additionally a few vehicle effects were fixed, most notable clicks in Helix Ambient Loops and Dragon Tank Attack, Decay. These clicks are caused if the start or end of a loop are not at 0 dB.

From my side this task is now complete.

@xezon xezon force-pushed the add-clean-english-sounds branch from 1627892 to a3393f7 Compare January 7, 2023 12:28
@xezon xezon force-pushed the add-clean-english-sounds branch from a3393f7 to 20082b8 Compare March 5, 2023 19:50
@xezon
Copy link
Contributor Author

xezon commented Mar 5, 2023

I did another review pass on all fixed sounds and fixed a few more things on around 60 of them. Next step for this is to split audio into smaller commit chunks to have a bit of an overview what was touched from commit.

@xezon xezon added USA Affects USA faction China Affects China faction GLA Affects GLA faction Audio Is audio related and removed Bug Something is not working right labels Apr 2, 2023
@xezon xezon force-pushed the add-clean-english-sounds branch from 132913e to 1c24b00 Compare April 2, 2023 14:48
xezon added a commit that referenced this pull request Apr 4, 2023
@xezon xezon force-pushed the add-clean-english-sounds branch from 1c24b00 to 0bd6db2 Compare April 4, 2023 06:49
@xezon xezon force-pushed the add-clean-english-sounds branch from 04b1c41 to a9fa77e Compare April 7, 2023 11:19
@xezon xezon merged commit d6a324b into main Apr 7, 2023
xezon added a commit that referenced this pull request Apr 7, 2023
@xezon xezon deleted the add-clean-english-sounds branch April 7, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Is audio related China Affects China faction GLA Affects GLA faction Major Severity: Minor < Major < Critical < Blocker Optional Is optional content USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some audio lines have humming recorded into them
2 participants