Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Convex Hull in C #3958

Merged
merged 31 commits into from
Nov 16, 2024
Merged

Add Convex Hull in C #3958

merged 31 commits into from
Nov 16, 2024

Conversation

2Clutch
Copy link
Contributor

@2Clutch 2Clutch commented Oct 28, 2024

I Am Adding a New Code Snippet in an Existing Language

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All output needs to match the project page. In general, all of the sample programs have a corresponding project page

@rzuckerm
Copy link
Collaborator

See this for the test failures.

@2Clutch
Copy link
Contributor Author

2Clutch commented Oct 29, 2024

See this for the test failures.

Thanks!

I have a good idea of how to navigate this now so I should be fine (I hope). I have a solution in place for all of the issues I was assigned, and I'm now refactoring and making sure it follows the project description to the letter.

I don't want to start over so I suspect each PR will have 1 or 2 failures before going through.

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are still failing. See this for details. Also, please review the project page again. The inputs are a list of X-coordinates and a list of Y-coordinates. The number of X- and Y-coordinates must be the same, and there must be at least 3 of them.

…Add checks for empty inputs, matching cardinality, and valid integers + Adjust output format to ensure correct line breaks for points
…t input validation for cases: no input, missing y, invalid shape, different cardinality, and invalid integers + Developed the Gift Wrapping algorithm to compute the convex hull + Ensure output format matches requirements for unit testing
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about your parsing algorithm is incorrect since there are errors like Invalid Integers for valid inputs. Please see this for details

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parsing still isn't right. The usage error message is being shown for all the cases. See this

@rzuckerm rzuckerm added enhancement Any code that improves the repo convex hull See: https://sampleprograms.io/projects/convex-hull/ labels Nov 1, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2Clutch I used your parsing from Binary Search to fix this.

@rzuckerm rzuckerm merged commit 7dc53c6 into TheRenegadeCoder:main Nov 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convex hull See: https://sampleprograms.io/projects/convex-hull/ enhancement Any code that improves the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Convex Hull in C
2 participants