Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Binary Search in C #3957

Merged
merged 12 commits into from
Oct 28, 2024
Merged

Modify Binary Search in C #3957

merged 12 commits into from
Oct 28, 2024

Conversation

2Clutch
Copy link
Contributor

@2Clutch 2Clutch commented Oct 28, 2024

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed Modify Binary Search in C #3956
  • I have read about modifying existing code snippets or tests in the [contributing documentation][contributing-modifications]
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

@rzuckerm rzuckerm added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related binary search See: https://sampleprograms.io/projects/binary-search/ labels Oct 28, 2024
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message for unsorted and invalid number still needs to say this:

Usage: please provide a list of sorted integers ("1, 4, 5, 11, 12") and the integer to find ("11")

Please see this for details on the failures.

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @2Clutch , looks good!

@rzuckerm rzuckerm merged commit 19ed281 into TheRenegadeCoder:main Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary search See: https://sampleprograms.io/projects/binary-search/ enhancement Any code that improves the repo hacktoberfest Hacktoberfest related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Binary Search in C
2 participants