Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Hello World in Egison #3793

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

rzuckerm
Copy link
Collaborator

@rzuckerm rzuckerm commented Apr 12, 2024

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed Modify Hello World in Egison #3792
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Apparently, egison has changed radically since this sample program was originally published. I couldn't get the "official" docker image to work, so I decided to just use the existing updated esolang/egison image.

This is also necessary to allow #3789 to be merged to close this security advisory.

@rzuckerm rzuckerm requested a review from jrg94 April 12, 2024 22:49
@rzuckerm rzuckerm marked this pull request as ready for review April 12, 2024 23:14
@rzuckerm rzuckerm added bug Something isn't working hello world See: https://sampleprograms.io/projects/hello-world/ labels Apr 13, 2024
@jrg94 jrg94 self-assigned this Apr 15, 2024
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jrg94 jrg94 merged commit d2dee83 into TheRenegadeCoder:main Apr 15, 2024
6 checks passed
@rzuckerm rzuckerm deleted the modify-hello-world-egison branch April 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hello world See: https://sampleprograms.io/projects/hello-world/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Hello World in Egison
2 participants