Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP-1504] Resolve Audiobook playback lockup #454

Merged
merged 72 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
ac385ec
Resolve TOC navigation errors
mauricecarrier7 Jun 26, 2024
36ca31d
Merge branch 'beta' into PP-1406/TOC-navigation-error
mauricecarrier7 Jun 26, 2024
b0f5904
integrate updated audiobook toolkit
mauricecarrier7 Jul 1, 2024
3cc2ee8
Update project.pbxproj
mauricecarrier7 Jul 1, 2024
64825fa
Merge branch 'beta' into fix/PP-1412-Properly-map-feedbook-audiobook-…
mauricecarrier7 Jul 1, 2024
6ebd4a9
Update project.pbxproj
mauricecarrier7 Jul 1, 2024
d2a7a59
Update project.pbxproj
mauricecarrier7 Jul 1, 2024
0ad395f
Update TPPBookCellDelegate+Extensions.swift
mauricecarrier7 Jul 1, 2024
58c1879
Update ios-audiobooktoolkit
mauricecarrier7 Jul 1, 2024
bb790d9
Prevent LCP lock on startup
mauricecarrier7 Jul 3, 2024
0cdd63a
Merge branch 'beta' into task/PP-1373-LCP-audiobooks-freeze-on-startup
mauricecarrier7 Jul 3, 2024
23253d7
Update project.pbxproj
mauricecarrier7 Jul 3, 2024
3cd00bd
Resolve token refresh issue
mauricecarrier7 Jul 9, 2024
2bc7349
add pretty printing extension for debugging
mauricecarrier7 Jul 9, 2024
58f95c1
Update ios-audiobooktoolkit
mauricecarrier7 Jul 9, 2024
423efb2
Update project.pbxproj
mauricecarrier7 Jul 9, 2024
6c59b23
Merge branch 'beta' into task/PP-1408-show-correct-title-for-chapters
mauricecarrier7 Jul 9, 2024
ba96dab
Update project.pbxproj
mauricecarrier7 Jul 9, 2024
fe5e5c6
Update project.pbxproj
mauricecarrier7 Jul 9, 2024
3f38a11
Update ios-audiobooktoolkit
mauricecarrier7 Jul 9, 2024
f0ac922
Update ios-audiobooktoolkit
mauricecarrier7 Jul 10, 2024
91a6324
Multiple fixes
mauricecarrier7 Jul 12, 2024
8696556
Merge branch 'beta' into task/PP-1422-properly-display-local-annotations
mauricecarrier7 Jul 12, 2024
257bd90
merge in dev
mauricecarrier7 Jul 12, 2024
34c3639
Update project.pbxproj
mauricecarrier7 Jul 12, 2024
6e8b84b
Clean up
mauricecarrier7 Jul 12, 2024
6346001
Ensure image update is not missed by callback
mauricecarrier7 Jul 15, 2024
7a7962a
Merge branch 'beta' into fix/PP-1364/Update-image-loader-to-avoid-rac…
mauricecarrier7 Jul 15, 2024
f2a8392
Update project.pbxproj
mauricecarrier7 Jul 15, 2024
c05fa45
Update TrackPosition+Annotations.swift
mauricecarrier7 Jul 17, 2024
28d4609
Update ios-audiobooktoolkit
mauricecarrier7 Jul 17, 2024
e203875
Update project.pbxproj
mauricecarrier7 Jul 17, 2024
b7b91f9
Update project.pbxproj
mauricecarrier7 Jul 17, 2024
3ad7f4e
Merge branch 'beta' into fix/PP-1373-resolve-LCP-delays
mauricecarrier7 Jul 17, 2024
5049295
Update project.pbxproj
mauricecarrier7 Jul 17, 2024
8917b2b
Update project.pbxproj
mauricecarrier7 Jul 17, 2024
c0ff6e2
Update project.pbxproj
mauricecarrier7 Jul 17, 2024
f6612f3
Properly map audiobookmarks to locator
mauricecarrier7 Jul 19, 2024
f97894c
Working implementation
mauricecarrier7 Jul 22, 2024
fc31e53
Capture time stamp from outer element of locator
mauricecarrier7 Jul 22, 2024
f02dff4
Move location saving to background thread
mauricecarrier7 Jul 23, 2024
1ab124d
Resolve syncing issues to prevent over uploading bookmarks
mauricecarrier7 Jul 25, 2024
2824a91
Add additional backward compatability support
mauricecarrier7 Jul 25, 2024
f96417e
Restore tests
mauricecarrier7 Jul 25, 2024
befae24
Restore audibookmark tests
mauricecarrier7 Jul 25, 2024
179491a
Improve bookmark syncing logic and code clean up
mauricecarrier7 Jul 25, 2024
1c507ba
Merge branch 'beta' into fix/PP-1438-ensure-cross-platform-annotation…
mauricecarrier7 Jul 25, 2024
9a85ce2
Update project.pbxproj
mauricecarrier7 Jul 25, 2024
5070527
Update project.pbxproj
mauricecarrier7 Jul 25, 2024
19bc8e8
Update project.pbxproj
mauricecarrier7 Jul 25, 2024
624fc71
Update project.pbxproj
mauricecarrier7 Jul 25, 2024
87c37b9
Update project.pbxproj
mauricecarrier7 Jul 25, 2024
74742fd
Update AudioBookmark.swift
mauricecarrier7 Jul 25, 2024
917ca58
Update TokenRequest.swift
mauricecarrier7 Jul 25, 2024
7536633
Update AudioBookmark.swift
mauricecarrier7 Jul 25, 2024
ffad943
Update AudiobookmarkTests.swift
mauricecarrier7 Jul 26, 2024
54d3fd0
Update ios-audiobooktoolkit
mauricecarrier7 Jul 30, 2024
480c6e6
Update project.pbxproj
mauricecarrier7 Jul 30, 2024
6941de9
Merge branch 'beta' into task/PP-1519-chatper-navigation-errors
mauricecarrier7 Jul 30, 2024
9ff3ed5
Update project.pbxproj
mauricecarrier7 Jul 30, 2024
6d57545
Update project.pbxproj
mauricecarrier7 Jul 30, 2024
dff49bd
Bump build number
mauricecarrier7 Aug 2, 2024
d309d28
Merge branch 'beta' into task/PP-1519-chatper-navigation-errors
mauricecarrier7 Aug 2, 2024
1b26731
Update project.pbxproj
mauricecarrier7 Aug 2, 2024
fdaea5e
Update project.pbxproj
mauricecarrier7 Aug 2, 2024
ddf4324
Update ios-audiobooktoolkit
mauricecarrier7 Aug 2, 2024
d82999b
Merge branch 'beta' into task/PP-1519-chatper-navigation-errors
mauricecarrier7 Aug 2, 2024
bdfc63b
Update project.pbxproj
mauricecarrier7 Aug 2, 2024
e1a2cb3
Resolve UI lockup on NonLCP books
mauricecarrier7 Aug 7, 2024
ad012e4
Update project.pbxproj
mauricecarrier7 Aug 7, 2024
1864ecc
Merge branch 'beta' into task/PP-1504-resolve-audiobook-playback-UI-lock
mauricecarrier7 Aug 7, 2024
3da72c0
Update project.pbxproj
mauricecarrier7 Aug 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Palace.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -5655,7 +5655,7 @@
CODE_SIGN_IDENTITY = "Apple Distribution";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 278;
CURRENT_PROJECT_VERSION = 279;
DEVELOPMENT_TEAM = 88CBA74T8K;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 88CBA74T8K;
ENABLE_BITCODE = NO;
Expand Down Expand Up @@ -5714,7 +5714,7 @@
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES_ERROR;
CODE_SIGN_ENTITLEMENTS = Palace/SimplyE.entitlements;
CODE_SIGN_IDENTITY = "iPhone Distribution";
CURRENT_PROJECT_VERSION = 278;
CURRENT_PROJECT_VERSION = 279;
DEVELOPMENT_TEAM = 88CBA74T8K;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 88CBA74T8K;
ENABLE_BITCODE = NO;
Expand Down Expand Up @@ -5899,7 +5899,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 278;
CURRENT_PROJECT_VERSION = 279;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 88CBA74T8K;
ENABLE_BITCODE = NO;
Expand Down Expand Up @@ -5960,7 +5960,7 @@
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES_ERROR;
CODE_SIGN_ENTITLEMENTS = Palace/SimplyE.entitlements;
CODE_SIGN_IDENTITY = "iPhone Distribution";
CURRENT_PROJECT_VERSION = 278;
CURRENT_PROJECT_VERSION = 279;
DEVELOPMENT_TEAM = 88CBA74T8K;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 88CBA74T8K;
ENABLE_BITCODE = NO;
Expand Down Expand Up @@ -6022,7 +6022,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 278;
CURRENT_PROJECT_VERSION = 279;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 88CBA74T8K;
ENABLE_BITCODE = NO;
Expand Down Expand Up @@ -6083,7 +6083,7 @@
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES_ERROR;
CODE_SIGN_ENTITLEMENTS = Palace/SimplyE.entitlements;
CODE_SIGN_IDENTITY = "iPhone Distribution";
CURRENT_PROJECT_VERSION = 278;
CURRENT_PROJECT_VERSION = 279;
DEVELOPMENT_TEAM = 88CBA74T8K;
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 88CBA74T8K;
ENABLE_BITCODE = NO;
Expand Down
34 changes: 23 additions & 11 deletions Palace/Book/UI/TPPBookCellDelegate+Extensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,26 @@ import PalaceAudiobookToolkit
let kServerUpdateDelay: Double = 30.0
let kTimerInterval: Double = 1.0

//TODO: This is a temporary solution to enable location saves from AppDelegate. Investigate a global context to manage state and introduce caching.
var latestAudiobookLocation: (book: String, location: String)?

private struct AssociatedKeys {
static var audiobookBookmarkBusinessLogic = "audiobookBookmarkBusinessLogic"
}

private let locationQueue = DispatchQueue(label: "com.palace.latestAudiobookLocation", attributes: .concurrent)
private var _latestAudiobookLocation: (book: String, location: String)?

var latestAudiobookLocation: (book: String, location: String)? {
get {
locationQueue.sync {
_latestAudiobookLocation
}
}
set {
locationQueue.async(flags: .barrier) {
_latestAudiobookLocation = newValue
}
}
}

extension TPPBookCellDelegate {
public func postListeningPosition(at location: String, completion: ((_ response: AnnotationResponse?) -> Void)? = nil) {
TPPAnnotations.postListeningPosition(forBook: self.book.identifier, selectorValue: location, completion: completion)
Expand All @@ -31,14 +44,12 @@ extension TPPBookCellDelegate {
return objc_getAssociatedObject(self, &AssociatedKeys.audiobookBookmarkBusinessLogic) as? AudiobookBookmarkBusinessLogic
}
set {
if let newValue = newValue {
objc_setAssociatedObject(
self,
&AssociatedKeys.audiobookBookmarkBusinessLogic,
newValue as AudiobookBookmarkBusinessLogic?,
.OBJC_ASSOCIATION_RETAIN_NONATOMIC
)
}
objc_setAssociatedObject(
self,
&AssociatedKeys.audiobookBookmarkBusinessLogic,
newValue,
.OBJC_ASSOCIATION_RETAIN_NONATOMIC
)
}
}

Expand Down Expand Up @@ -264,6 +275,7 @@ extension TPPBookCellDelegate {
let locationString = String(data: locationData ?? Data(), encoding: .utf8) ?? ""

TPPBookRegistry.shared.setLocation(TPPBookLocation(locationString: locationString, renderer: "PalaceAudiobookToolkit"), forIdentifier: self.book.identifier)

latestAudiobookLocation = (book: self.book.identifier, location: locationString)
}
}
Expand Down
10 changes: 8 additions & 2 deletions Palace/Reader2/Bookmarks/AudiobookBookmarkBusinessLogic.swift
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ import PalaceAudiobookToolkit
}

// MARK: - Bookmark Management

public func saveListeningPosition(at position: TrackPosition, completion: ((String?) -> Void)?) {
debounce {
self.saveListeningPositionImmediate(at: position, completion: completion)
}
}

private func saveListeningPositionImmediate(at position: TrackPosition, completion: ((String?) -> Void)?) {
let audioBookmark = position.toAudioBookmark()
audioBookmark.lastSavedTimeStamp = Date().iso8601
guard let tppLocation = audioBookmark.toTPPBookLocation() else {
Expand All @@ -50,7 +56,7 @@ import PalaceAudiobookToolkit
}
}
}

public func saveBookmark(at position: TrackPosition, completion: ((_ position: TrackPosition?) -> Void)? = nil) {
debounce {
Task {
Expand Down
Loading