PP-1373 Resolve LCP lockup #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauricecarrier7
added a commit
that referenced
this pull request
Aug 16, 2024
* [PP-1064] Audiobook refactor infrastructure (#78) * Initial infrastructure implementation + manifest class tests * Clean up author parsing * Implement table of contents with working tests * Implements and tests track, tracks and trackPosiiton * Clean up * Further clean up * Clean up * Final clean up * [PP-1065] Refactor audiobook classes (#79) * Adapt manifest and Tracks to support Findaway structure * Clean up toc tests * Update audiobook classes * Update Manifest to support OVerdrive * Update tests to support Overdrive manifests * PR clean up * [PP-1066][PP-1067] Update audiobook players and UI (#80) * Adapt manifest and Tracks to support Findaway structure * Clean up toc tests * Update audiobook classes * Update Manifest to support OVerdrive * Update tests to support Overdrive manifests * PR clean up * Update OpenAccessPlayer, deprecate old players * Clean up * Begin mirgrating players * Fix tests * building open access happy path * Update OpenAccess player UI elements * Fire sale, semi working player * Working playback publisher * LCP support * Fix track building and seeking * Working LCP Player * Fix chapter mapping * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Pass token to download task * Implement LCP DownloadTask, OverdriveDownloadTask * Move findaway player to main app * Further findaway progress * Working findaway implementation * All basic working functionality * Update to support spine based manifest * Track overall download progress * Resolve download freezing errors * Remove dead code * Clean up * Clean up * Move Findaway into main app * Clean up tests * Fix movements and chapter location * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update ManifestDecodingTests.swift * Update ManifestDecodingTests.swift * Remove dead code * Restore end of playback alert * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update TableOfContentsTests.swift * Update ChapterCell.swift * Update project.pbxproj * Update project.pbxproj * Clean up download issues and crash * Clean up threading issues * Fix further concurrency issues and improve performance * [PP-1068] Update track position and annotations (#82) * Working track position on track start, restore tests * Update bookmarks * Update AudiobookManager.swift * Delete AudiobookBookmarkBusinessLogic.swift * Update ManifestJSON.swift * Ensure table of contents titles are pulled from table of contents * Resolve outstanding bugs * Update SleepTimer.swift * Update track key creation, ensure location is saved * Implement download retry on TOC (#84) * PP-1372 Change audiobook download order * PP-1371 Show correct title on lock screen * Progressively decrypt LCP books to prevent UI lock * Update LCPPlayer.swift * Update FindawayDownloadTask.swift * Update LCPPlayer.swift * Update OpenAccessPlayer.swift (#86) * Support feedbook manifest properly * Update manifest * Clean up * Update OpenAccessPlayer.swift * [PP-1412] Properly map Feedbook audiobook manifests (#87) * Support feedbook manifest properly * Update manifest * Clean up * Update OpenAccessPlayer.swift * Update OpenAccessAudiobook.swift * Clean up * Update LCPPlayer.swift * PP-1407-Update home screen controls * PP-1373 LCP audiobooks freeze on startup * PP-1408 Update how chapter titles are displayed (#88) * Properly parse findaway books with null title * Show correct title for overdrive books * Rebuild player when needed * Fix findaway track annotations * Display findaway chapter titles correctly * [PP-1422] Properly display local annotations (#89) * properly display local bookmarks * Update AudiobookTableOfContents.swift * Update AudiobookPlaybackModel.swift * PP-1373 Resolve LCP lockup (#90) * Resolve LCP lockup * Clean up * Improve audiobook management to support android synchronization (#91) * Resolves TOC and navigation errors * Revert "Resolves TOC and navigation errors" This reverts commit 7be676c. * Resolves TOC and navigation errors (#92) * [PP-1510] resolve overdrive bitrate issues (#93) * Resolves TOC and navigation errors * Resolve OverdriveTrack bitrate and duration issues * Delete OpenAccessPlayer.swift.orig * Update LCPPlayer.swift * Update LCPPlayer.swift * Update OpenAccessPlayer.swift (#94)
mauricecarrier7
added a commit
that referenced
this pull request
Aug 19, 2024
* [PP-1064] Audiobook refactor infrastructure (#78) * Initial infrastructure implementation + manifest class tests * Clean up author parsing * Implement table of contents with working tests * Implements and tests track, tracks and trackPosiiton * Clean up * Further clean up * Clean up * Final clean up * [PP-1065] Refactor audiobook classes (#79) * Adapt manifest and Tracks to support Findaway structure * Clean up toc tests * Update audiobook classes * Update Manifest to support OVerdrive * Update tests to support Overdrive manifests * PR clean up * [PP-1066][PP-1067] Update audiobook players and UI (#80) * Adapt manifest and Tracks to support Findaway structure * Clean up toc tests * Update audiobook classes * Update Manifest to support OVerdrive * Update tests to support Overdrive manifests * PR clean up * Update OpenAccessPlayer, deprecate old players * Clean up * Begin mirgrating players * Fix tests * building open access happy path * Update OpenAccess player UI elements * Fire sale, semi working player * Working playback publisher * LCP support * Fix track building and seeking * Working LCP Player * Fix chapter mapping * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Pass token to download task * Implement LCP DownloadTask, OverdriveDownloadTask * Move findaway player to main app * Further findaway progress * Working findaway implementation * All basic working functionality * Update to support spine based manifest * Track overall download progress * Resolve download freezing errors * Remove dead code * Clean up * Clean up * Move Findaway into main app * Clean up tests * Fix movements and chapter location * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update ManifestDecodingTests.swift * Update ManifestDecodingTests.swift * Remove dead code * Restore end of playback alert * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update TableOfContentsTests.swift * Update ChapterCell.swift * Update project.pbxproj * Update project.pbxproj * Clean up download issues and crash * Clean up threading issues * Fix further concurrency issues and improve performance * [PP-1068] Update track position and annotations (#82) * Working track position on track start, restore tests * Update bookmarks * Update AudiobookManager.swift * Delete AudiobookBookmarkBusinessLogic.swift * Update ManifestJSON.swift * Ensure table of contents titles are pulled from table of contents * Resolve outstanding bugs * Update SleepTimer.swift * Update track key creation, ensure location is saved * Implement download retry on TOC (#84) * PP-1372 Change audiobook download order * PP-1371 Show correct title on lock screen * Progressively decrypt LCP books to prevent UI lock * Update LCPPlayer.swift * Update FindawayDownloadTask.swift * Update LCPPlayer.swift * Update OpenAccessPlayer.swift (#86) * Support feedbook manifest properly * Update manifest * Clean up * Update OpenAccessPlayer.swift * [PP-1412] Properly map Feedbook audiobook manifests (#87) * Support feedbook manifest properly * Update manifest * Clean up * Update OpenAccessPlayer.swift * Update OpenAccessAudiobook.swift * Clean up * Update LCPPlayer.swift * PP-1407-Update home screen controls * PP-1373 LCP audiobooks freeze on startup * PP-1408 Update how chapter titles are displayed (#88) * Properly parse findaway books with null title * Show correct title for overdrive books * Rebuild player when needed * Fix findaway track annotations * Display findaway chapter titles correctly * [PP-1422] Properly display local annotations (#89) * properly display local bookmarks * Update AudiobookTableOfContents.swift * Update AudiobookPlaybackModel.swift * PP-1373 Resolve LCP lockup (#90) * Resolve LCP lockup * Clean up * Improve audiobook management to support android synchronization (#91) * Resolves TOC and navigation errors * Revert "Resolves TOC and navigation errors" This reverts commit 7be676c. * Resolves TOC and navigation errors (#92) * [PP-1510] resolve overdrive bitrate issues (#93) * Resolves TOC and navigation errors * Resolve OverdriveTrack bitrate and duration issues * Delete OpenAccessPlayer.swift.orig * Update LCPPlayer.swift * Update LCPPlayer.swift * Update OpenAccessPlayer.swift (#94) * Performance improvements trial 1 * Update AudiobookManager.swift * Update AudiobookManager.swift * Update AudiobookManager.swift * Clean up extraneous spaces
mauricecarrier7
added a commit
that referenced
this pull request
Aug 19, 2024
* [PP-1064] Audiobook refactor infrastructure (#78) * Initial infrastructure implementation + manifest class tests * Clean up author parsing * Implement table of contents with working tests * Implements and tests track, tracks and trackPosiiton * Clean up * Further clean up * Clean up * Final clean up * [PP-1065] Refactor audiobook classes (#79) * Adapt manifest and Tracks to support Findaway structure * Clean up toc tests * Update audiobook classes * Update Manifest to support OVerdrive * Update tests to support Overdrive manifests * PR clean up * [PP-1066][PP-1067] Update audiobook players and UI (#80) * Adapt manifest and Tracks to support Findaway structure * Clean up toc tests * Update audiobook classes * Update Manifest to support OVerdrive * Update tests to support Overdrive manifests * PR clean up * Update OpenAccessPlayer, deprecate old players * Clean up * Begin mirgrating players * Fix tests * building open access happy path * Update OpenAccess player UI elements * Fire sale, semi working player * Working playback publisher * LCP support * Fix track building and seeking * Working LCP Player * Fix chapter mapping * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Pass token to download task * Implement LCP DownloadTask, OverdriveDownloadTask * Move findaway player to main app * Further findaway progress * Working findaway implementation * All basic working functionality * Update to support spine based manifest * Track overall download progress * Resolve download freezing errors * Remove dead code * Clean up * Clean up * Move Findaway into main app * Clean up tests * Fix movements and chapter location * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update ManifestDecodingTests.swift * Update ManifestDecodingTests.swift * Remove dead code * Restore end of playback alert * Update OpenAccessPlayer.swift * Update OpenAccessPlayer.swift * Update TableOfContentsTests.swift * Update ChapterCell.swift * Update project.pbxproj * Update project.pbxproj * Clean up download issues and crash * Clean up threading issues * Fix further concurrency issues and improve performance * [PP-1068] Update track position and annotations (#82) * Working track position on track start, restore tests * Update bookmarks * Update AudiobookManager.swift * Delete AudiobookBookmarkBusinessLogic.swift * Update ManifestJSON.swift * Ensure table of contents titles are pulled from table of contents * Resolve outstanding bugs * Update SleepTimer.swift * Update track key creation, ensure location is saved * Implement download retry on TOC (#84) * PP-1372 Change audiobook download order * PP-1371 Show correct title on lock screen * Progressively decrypt LCP books to prevent UI lock * Update LCPPlayer.swift * Update FindawayDownloadTask.swift * Update LCPPlayer.swift * Update OpenAccessPlayer.swift (#86) * Support feedbook manifest properly * Update manifest * Clean up * Update OpenAccessPlayer.swift * [PP-1412] Properly map Feedbook audiobook manifests (#87) * Support feedbook manifest properly * Update manifest * Clean up * Update OpenAccessPlayer.swift * Update OpenAccessAudiobook.swift * Clean up * Update LCPPlayer.swift * PP-1407-Update home screen controls * PP-1373 LCP audiobooks freeze on startup * PP-1408 Update how chapter titles are displayed (#88) * Properly parse findaway books with null title * Show correct title for overdrive books * Rebuild player when needed * Fix findaway track annotations * Display findaway chapter titles correctly * [PP-1422] Properly display local annotations (#89) * properly display local bookmarks * Update AudiobookTableOfContents.swift * Update AudiobookPlaybackModel.swift * PP-1373 Resolve LCP lockup (#90) * Resolve LCP lockup * Clean up * Improve audiobook management to support android synchronization (#91) * Resolves TOC and navigation errors * Revert "Resolves TOC and navigation errors" This reverts commit 7be676c. * Resolves TOC and navigation errors (#92) * [PP-1510] resolve overdrive bitrate issues (#93) * Resolves TOC and navigation errors * Resolve OverdriveTrack bitrate and duration issues * Delete OpenAccessPlayer.swift.orig * Update LCPPlayer.swift * Update LCPPlayer.swift * Update OpenAccessPlayer.swift (#94) * Performance improvements trial 1 * Update AudiobookManager.swift * Update AudiobookManager.swift * Update AudiobookManager.swift * Clean up extraneous spaces * Update AudiobookManager.swift * Update AudiobookManager.swift * Update AudiobookManager.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ebce-lyrasis.atlassian.net/browse/PP-1373