Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move analytics provider into service.analytics package #2322

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

jonathangreen
Copy link
Member

@jonathangreen jonathangreen commented Mar 6, 2025

Description

Move our analytics provider into the palace.manager.service.analytics package.

When these files were moved, it started causing some type errors, because everything in service has strict type checking enabled, so I also added some type hints that were missing in:

  • Local analytics
  • S3 analytics
  • CirculationEvent model

Motivation and Context

Doing this as part of some refactoring work in PP-1470.

This PR sets up some more analytics refactoring done in #2323.

How Has This Been Tested?

  • Ran tests

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from dbernstein March 6, 2025 19:26
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (2b13b3c) to head (62b0e77).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2322   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         362      362           
  Lines       41343    41343           
  Branches     8855     8855           
=======================================
  Hits        37729    37729           
  Misses       2352     2352           
  Partials     1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏽

@jonathangreen jonathangreen merged commit 7027932 into main Mar 7, 2025
19 checks passed
@jonathangreen jonathangreen deleted the chore/move-analytics-provider branch March 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants