Move analytics provider into service.analytics package #2322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move our analytics provider into the
palace.manager.service.analytics
package.When these files were moved, it started causing some type errors, because everything in
service
has strict type checking enabled, so I also added some type hints that were missing in:CirculationEvent
modelMotivation and Context
Doing this as part of some refactoring work in PP-1470.
This PR sets up some more analytics refactoring done in #2323.
How Has This Been Tested?
Checklist