Coding Style (PHP-CS-Fixer) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflict is resolved and PR ready. Let me know, if proposed changes are fine or any adjustments are necessary. Thanks. |
|
Awesome, thanks for the PR! I have now merged this. I think it is great to have a code-style defined and enforced. |
|
My pleasure! Would be nice to add the information in the contributing section of the readme on how to install/run php-cs-fixer, so people actually know about it. :) Maybe I get to it next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PHP-CS-Fixer configuration.
Fixed coding standard issues via php-cs-fixer.
Closes #71