Merge pull request #92 from inigo-cobian/dont-require-raster-extension

Remove not supporting raster extension as a non valid reason
TheHortonMachine · May 10, 2024 · 584afd5 · 584afd5
2 parents 7815ea8 + c7a1230
commit 584afd5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/gears/src/main/java/org/hortonmachine/gears/io/stac/HMStacAsset.java b/gears/src/main/java/org/hortonmachine/gears/io/stac/HMStacAsset.java
@@ -49,9 +49,8 @@ public HMStacAsset( String id, JsonNode assetNode ) {
             }
             if (type.toLowerCase().contains("profile=cloud-optimized")) {
                 JsonNode rasterBandNode = assetNode.get("raster:bands");
+                assetUrl = assetNode.get("href").textValue();
                 if (rasterBandNode != null && !rasterBandNode.isEmpty()) {
-                    assetUrl = assetNode.get("href").textValue();
-
                     Iterator<JsonNode> rbIterator = rasterBandNode.elements();
                     while( rbIterator.hasNext() ) {
                         JsonNode rbNode = rbIterator.next();
@@ -64,9 +63,6 @@ public HMStacAsset( String id, JsonNode assetNode ) {
                             resolution = resolNode.asDouble();
                         }
                     }
-                } else {
-                    isValid = false;
-                    nonValidReason = "raster bands metadata missing";
                 }
             } else {
                 isValid = false;

diff --git a/gears/src/test/java/org/hortonmachine/gears/modules/TestStacAsset.java b/gears/src/test/java/org/hortonmachine/gears/modules/TestStacAsset.java
@@ -52,15 +52,14 @@ public void testCreateInvalidStacAssetNotACOG() throws JsonProcessingException {
         assertEquals("not a COG", asset.getNonValidReason());
     }
 
-    public void testCreateInvalidStacAssetRasterBandsMetadataMissing() throws JsonProcessingException {
+    public void testCreateStacAssetRasterBandsMetadataMissingIsValid() throws JsonProcessingException {
         String assetJSON = "{\"title\":\"Band 1 (coastal) BOA reflectance\",\"type\":\"image/tiff; application=geotiff; profile=cloud-optimized\",\"roles\":[\"data\"],\"gsd\":60,\"eo:bands\":[{\"name\":\"B01\",\"common_name\":\"coastal\",\"center_wavelength\":0.4439,\"full_width_half_max\":0.027}],\"href\":\"https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/33/S/VB/2021/2/S2B_33SVB_20210221_0_L2A/B01.tif\",\"proj:shape\":[1830,1830],\"proj:transform\":[60,0,399960,0,-60,4200000,0,0,1],\"raster:bands\":[]}";
         ObjectMapper mapper = new ObjectMapper();
         JsonNode node = mapper.readTree(assetJSON);
 
         HMStacAsset asset = new HMStacAsset("B01", node);
 
-        assertFalse(asset.isValid());
-        assertEquals("raster bands metadata missing", asset.getNonValidReason());
+        assertTrue(asset.isValid());
     }
 
 }