Change the link back to VirusTotal Template using content.permalink #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exists, and use that to link back to VirusTotal report instead of hand-crafted link, only when the scan was a scan of a URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For VirusTotal_Scan long report summary, check if content.permalink
exists, and use that to link back to VirusTotal report instead of
hand-crafted link, only when the scan was a scan of a URL.
I don't know why the template had the link back only set for URL scans, however, I found that all types of scans seem to provide a permalink, so I only check if content.permalink exists, and if so, use that as the link back to VirusTotal.
Additionally I also observed, that the former hand crafted link back to VirusTotal did not worked for all URL scans.