-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GreyNoise - Update API to new version 3 #911
Conversation
GreyNoise analyzer v3
Greynoise analyzer v3
Make levels lower case
analyzers/GreyNoise/greynoisev3.py
Outdated
|
||
if self.data_type == "ip": | ||
api_key = self.get_param('config.key', None) | ||
api_client = GreyNoise(api_key=api_key, timeout=30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markus-nclose : can we also get an integration name passed here?
Example:
api_client = GreyNoise(api_key=api_key, integration_name="greynoise-cortex-analyzer-v3.0")
We're working to set this up as our standard going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as requested above, looks like the only use is in the user-agent header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes that is correct, this is essentially a user-agent string for us to see on the backend. It helps us understand the adoption and use of integrations with our service and we can also proactively let users know there is a new version available if we see high usage of older versions.
I merged the pull in develop because I really liked the api approach and then I found out that I was working on it in different branch to fix documentation so I had to merge our forces 😄 You can find updates here:
Changes:
Sorry for the confusion! If you have any other feedback (eg. how to improve docs) let me know! |
No description provided.