Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreyNoise - Update API to new version 3 #911

Merged
merged 10 commits into from
Feb 3, 2021

Conversation

markus-nclose
Copy link
Contributor

No description provided.

@markus-nclose
Copy link
Contributor Author

#912


if self.data_type == "ip":
api_key = self.get_param('config.key', None)
api_client = GreyNoise(api_key=api_key, timeout=30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markus-nclose : can we also get an integration name passed here?

Example:
api_client = GreyNoise(api_key=api_key, integration_name="greynoise-cortex-analyzer-v3.0")

We're working to set this up as our standard going forward.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as requested above, looks like the only use is in the user-agent header?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes that is correct, this is essentially a user-agent string for us to see on the backend. It helps us understand the adoption and use of integrations with our service and we can also proactively let users know there is a new version available if we see high usage of older versions.

@dadokkio dadokkio changed the base branch from master to develop February 3, 2021 08:51
@dadokkio dadokkio merged commit 42bc386 into TheHive-Project:develop Feb 3, 2021
@dadokkio
Copy link
Contributor

dadokkio commented Feb 3, 2021

I merged the pull in develop because I really liked the api approach and then I found out that I was working on it in different branch to fix documentation so I had to merge our forces 😄

You can find updates here:

Changes:

  • removed requests since it's not used anymore
  • used python3 in #!
  • moved templates in _3_0 folder and update to new json results

Sorry for the confusion! If you have any other feedback (eg. how to improve docs) let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants