Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSCD Initiative] Add Azure Authentication Token Revokation Responder #906

Merged
merged 6 commits into from
Jul 21, 2021

Conversation

districtofpaige
Copy link
Contributor

Hello, please see the supplied AzureTokenRevoker responder .py, .json, and requirements.txt files.

Two outstanding issues within the responder's .py codew:
1.) I was not able to clear up, is what the get_params data path was for a submitted UPN within a case. Would it be "data.data"? Or something else?

2.) Will a self.report statement with a message be sufficient as a return of success? Or is there some other object I should be passing back to TheHive?

@yugoslavskiy
Copy link
Contributor

Hello @Dmweiner! Sorry for the delayed reply. We still work on the OSCD sprint finalization.
Let's try to tag the maintainers and get your questions answered!

@nadouani @jeromeleonard guys could you please give us a hand?

@nadouani nadouani requested a review from dadokkio March 30, 2021 08:48
@nadouani
Copy link
Contributor

Hello, please see the supplied AzureTokenRevoker responder .py, .json, and requirements.txt files.

Two outstanding issues within the responder's .py codew:
1.) I was not able to clear up, is what the get_params data path was for a submitted UPN within a case. Would it be "data.data"? Or something else?

2.) Will a self.report statement with a message be sufficient as a return of success? Or is there some other object I should be passing back to TheHive?

Hello @Dmweiner

1/ using data.data you get access to the case send by TheHive to the responder. Where do you store the UPN within a case?
2/ technically this is enough, I would return an operation like adding a tag to the case or observable.

@nadouani nadouani added this to the 3.0.0 milestone Jul 21, 2021
@jeromeleonard jeromeleonard merged commit a4e9481 into TheHive-Project:feature/oscd Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants