Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velociraptor: Add upload functionality for flow results #852

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

weslambert
Copy link
Contributor

  • Adds the ability to upload flow results as a case observable.
  • Other improvements

@weslambert weslambert changed the title Add upload functionality for flow results Velociraptor: Add upload functionality for flow results Sep 15, 2020
@weslambert
Copy link
Contributor Author

@dadokkio @garanews Any chance this could be included in the next release?

@dadokkio
Copy link
Contributor

dadokkio commented Oct 2, 2020

I need @jeromeleonard feedback.. I always forget our policy regardind responder that uses thehive api 👼

@weslambert
Copy link
Contributor Author

@jeromeleonard did you have any feedback?

@weslambert
Copy link
Contributor Author

Following up on this. Any thoughts @jeromeleonard @nadouani?

@jeromeleonard
Copy link
Contributor

hello @weslambert. The fact is that we do not recommend making a responder connect back to TheHive, unless there is no other choice.

Like with Analyzers, Responders can add observables to a case when successfully run with the operation "AddArtifactToCase". For the moment, this cannot handle observables of type file but this is something we are considering in the coming releases of TheHive and Cortex. Seeing the growing need, we know this should be prioritized. We are currently looking at the amount of work it needs to decide when it comes. I keep you posted.

@weslambert
Copy link
Contributor Author

Hi @jeromeleonard , thanks for the response.

The use case is to have the results/artifacts sent back to TheHive for correlation with the case details, tracking, etc (in this case, as a zip file). Additionally, some folks may have access to TheHive, but not to Velociraptor itself, so this may be the only way that they can view/retrieve this data alongside a case (approved artifacts/flows that are allowed to be run via responder, etc).

The current VirustotalDownloader responder here essentially does the same/a very similar thing:

https://github.com/TheHive-Project/Cortex-Analyzers/blob/master/responders/VirustotalDownloader/VirustotalDownloader.py#L52

@weslambert
Copy link
Contributor Author

@jeromeleonard Could it be possible to merge this for the time being, since this is not much different from the VT Downloader responder, then adjust as needed once the aforementioned functionality is available?

@jeromeleonard jeromeleonard added this to the 3.0.0 milestone Oct 21, 2020
@jeromeleonard jeromeleonard added category:enhancement Issue is related to an existing feature to improve scope:responder Issues/PRs pertaining to responders labels Oct 21, 2020
@jeromeleonard
Copy link
Contributor

Yes, we'll integrate it in the next release. Can I ask you to update the README.md file please ? This will update to documentation page: https://thehive-project.github.io/Cortex-Analyzers/responders/Velociraptor/

@weslambert
Copy link
Contributor Author

Yep, will do. Thanks!

@weslambert
Copy link
Contributor Author

@jeromeleonard @dadokkio would it be possible to add to this before merging? I would like to make some updates.

@dadokkio
Copy link
Contributor

dadokkio commented Mar 3, 2021

This has not been merged yes, so yes.
I wanted to test it, but then I had issues with velociraptor docker.

Regarding the necessity to use thehive api from responder I've for example added download sample functionality to VirusTotal analyzer without them, so there are still doubts of doing this.

@nadouani
Copy link
Contributor

@weslambert I'll merge this one, and you could update it afterward? Is this OK for you?

@weslambert
Copy link
Contributor Author

Hi @nadouani,

That would be fine, however I've not tested this in a while.

@nadouani nadouani modified the milestones: 3.0.0, 3.1.0 Jan 23, 2022
@jeromeleonard jeromeleonard self-requested a review January 25, 2022 10:28
@jeromeleonard jeromeleonard self-assigned this Jan 25, 2022
jeromeleonard added a commit that referenced this pull request Jan 25, 2022
@jeromeleonard jeromeleonard merged commit ae2118c into TheHive-Project:develop Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:enhancement Issue is related to an existing feature to improve scope:responder Issues/PRs pertaining to responders status:needs-docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants