Updates to Virusshare analyzer #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think my python script that downloads the hashes can be deleted. That bash script is much more cleaner. |
|
Why does capitzalizing the first letter of |
|
You are correct :) I missed that, sorry.
I have implemented a better (lazier) fix so that the templates are not
affected... I generally prefer not to have case in internal marker strings
anyway. :P
…On Fri, Aug 25, 2017 at 11:04 PM Nils Kuhnert ***@***.***> wrote:
Think you have to modify the templates as well, because you changed
unknown to Unknown.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AISq-pJHBFGZ46iR2XhlG1hGe0miOn4Gks5sbzbBgaJpZM4Oc7s4>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added case insensitivity to the hash comparison within the analyzer. This is important because Virusshare stores all lowercase hashes, but if you compare an uppercase hash, it will always returns as not within the Virusshare dataset which can be dangerously incorrect.
I have benchmarked the comparison and found that the removal of the strip function actually improved the overall speed of the test when a line contains a single hash. Moving to the 'in' operator also allows for support of the UPX hash map file that has been created.
I've also added a simple bash script to fetch the hashes since I had issues with python version that is available. Bash is simpler and more or less always works as expected whereas python could apparently have issue that are harder to fix than (in this case) simply writing a bash based tool.