Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abuse_Finder : Add support to Python3.6 #469

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Abuse_Finder : Add support to Python3.6 #469

merged 1 commit into from
Dec 26, 2019

Conversation

LetMeR00t
Copy link
Contributor

This change is not enough (of course), it needs this PR to be merged :
certsocietegenerale/abuse_finder#3

@LetMeR00t
Add support to Python3.6
77e7293 
This change is not enough (of course), it needs this PR to be merged :
certsocietegenerale/abuse_finder#3
@LetMeR00t LetMeR00t mentioned this pull request Apr 21, 2019
Closed
5 tasks
@3c7 3c7 added scope:analyzer Issue is analyzer related category:enhancement Issue is related to an existing feature to improve status:pr-submitted labels Jun 16, 2019
@jeromeleonard jeromeleonard changed the base branch from master to develop November 17, 2019 13:52
@LetMeR00t
Copy link
Contributor Author

Hi guys,
My PR has been accepted.
This PR should be ready now :)

@nadouani
Copy link
Contributor

Can you try to install the dependencies and make sure the analyzer works?

@LetMeR00t
Copy link
Contributor Author

LetMeR00t commented Dec 26, 2019 •
edited
Loading

I will try this ASAP.

@nadouani nadouani self-requested a review December 26, 2019 21:56
@nadouani nadouani merged commit 47b7762 into TheHive-Project:develop Dec 26, 2019
@nadouani nadouani added this to the 2.4.0 milestone Dec 26, 2019
@LetMeR00t
Copy link
Contributor Author

Hi @nadouani ,
I've tested with this command after installing the requirements.txt using pip3:
echo '{"data":"8.8.8.8","dataType":"ip"}' | python3 abusefinder.py

I've no issue with the abuse_finder 0.2 package version

@LetMeR00t LetMeR00t deleted the abusefinder_python3.6 branch December 27, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadouani nadouani Awaiting requested review from nadouani

Assignees
No one assigned
Labels
category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LetMeR00t @nadouani @3c7